lukechilds/node - node - Gitea: Git with a cup of tea

16652 Commits

131 Branches

446 Tags

325 MiB

Tree: 90fcccd7a3

Commit Graph

Author	SHA1	Message	Date
Rich Trott	4a3e089984	test: confirm callback is invoked in fs test Use common.mustCall() in test-fs-makeStatsCallback to confirm that the callback is invoked. PR-URL: https://github.com/nodejs/node/pull/13132 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Michael Dawson <mhdawson@ibm.com> Reviewed-By: Alexey Orlenko <eaglexrlnk@gmail.com> Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>	8 years ago
Luca Maraschi	e6d6a4111c	test: extended test to makeCallback cb type check makeCallback and makeStatsCallback are both tested intedependently. PR-URL: https://github.com/nodejs/node/pull/12140 Backport-PR-URL: https://github.com/nodejs/node/pull/13785 Fixes: https://github.com/nodejs/node/issues/12136 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>	8 years ago

Author

SHA1

Message

Date

Rich Trott

4a3e089984

test: confirm callback is invoked in fs test

Use common.mustCall() in test-fs-makeStatsCallback to confirm that the
callback is invoked.

PR-URL: https://github.com/nodejs/node/pull/13132
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Michael Dawson <mhdawson@ibm.com>
Reviewed-By: Alexey Orlenko <eaglexrlnk@gmail.com>
Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>

8 years ago

Luca Maraschi

e6d6a4111c

test: extended test to makeCallback cb type check

makeCallback and makeStatsCallback are both tested intedependently.

PR-URL: https://github.com/nodejs/node/pull/12140
Backport-PR-URL: https://github.com/nodejs/node/pull/13785
Fixes: https://github.com/nodejs/node/issues/12136
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>

8 years ago

2 Commits (90fcccd7a35834780dd838eff941de188d25cb45)