lukechilds/node - node - Gitea: Git with a cup of tea

13899 Commits

131 Branches

446 Tags

325 MiB

Tree: 9196d87704

Commit Graph

Author	SHA1	Message	Date
Myles Borins	0c62bd13fb	test: ensure test-npm-install uses correct node Currently it is possible that the shelled out instance of npm will use the system copy of node. This PR changes the test to shim the build directory into the path. This will ensure that npm will use the correct version of node. fixes: https://github.com/nodejs/node/issues/6648 PR-URL: https://github.com/nodejs/node/pull/6658 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com> Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>	9 years ago
Santiago Gimeno	fbe0b444ef	test: improve test-npm-install Make npm install a dependency that is defined as a relative path, so it avoids any network interaction. PR-URL: https://github.com/nodejs/node/pull/5613 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Claudio Rodriguez <cjrodr@yahoo.com>	9 years ago
Myles Borins	061ebb39c9	test: add test-npm-install to parallel tests suite Currently we are not testing that `npm install` works. This is a very naive / basic test that shells out to `npm install` in an empty `tempDir`. While this test will not be able to check that `npm install` is 100% working, it should catch certain edge cases that break it. PR-URL: https://github.com/nodejs/node/pull/5166 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Alexis Campailla <orangemocha@nodejs.org>	9 years ago

Author

SHA1

Message

Date

Myles Borins

0c62bd13fb

test: ensure test-npm-install uses correct node

Currently it is possible that the shelled out instance of npm will use
the system copy of node. This PR changes the test to shim the build
directory into the path. This will ensure that npm will use the correct
version of node.

fixes: https://github.com/nodejs/node/issues/6648

PR-URL: https://github.com/nodejs/node/pull/6658
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>

9 years ago

Santiago Gimeno

fbe0b444ef

test: improve test-npm-install

Make npm install a dependency that is defined as a relative path, so it
avoids any network interaction.

PR-URL: https://github.com/nodejs/node/pull/5613
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Claudio Rodriguez <cjrodr@yahoo.com>

9 years ago

Myles Borins

061ebb39c9

test: add test-npm-install to parallel tests suite

Currently we are not testing that `npm install` works.

This is a very naive / basic test that shells out to `npm install`
in an empty `tempDir`. While this test will not be able to check
that `npm install` is 100% working, it should catch certain edge
cases that break it.

PR-URL: https://github.com/nodejs/node/pull/5166
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Alexis Campailla <orangemocha@nodejs.org>

9 years ago

3 Commits (9196d87704b3cd86c87fe1c33d0a8aa69424a96a)