lukechilds/node - node - Gitea: Git with a cup of tea

14276 Commits

131 Branches

446 Tags

325 MiB

Tree: 919e0cb8f2

Commit Graph

Author SHA1 Message Date

Author	SHA1	Message	Date
Raja Panidepu	1e53cf4764	test: updated test-stream-pipe-unpipe-stream test readableStream.unpipe(dest) is no operation when dest is not a destination for readable stream. PR-URL: https://github.com/nodejs/node/pull/10100 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com>	8 years ago
Niels Nielsen	d9c33646e6	test: add regression test for `unpipe()` Since `2e568d9` there is a bug where unpiping a stream from a readable stream that has `_readableState.pipesCount > 1` will cause it to remove the first stream in the `_.readableState.pipes` array no matter where in the list the `dest` stream was. Ref: https://github.com/nodejs/node/pull/9553 PR-URL: https://github.com/nodejs/node/pull/9171 Reviewed-By: Evan Lucas <evanlucas@me.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Myles Borins <myles.borins@gmail.com>	8 years ago

Raja Panidepu

1e53cf4764

test: updated test-stream-pipe-unpipe-stream

test readableStream.unpipe(dest) is no operation when dest is
not a destination for readable stream.

PR-URL: https://github.com/nodejs/node/pull/10100
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>

8 years ago

Niels Nielsen

d9c33646e6

test: add regression test for `unpipe()`

Since 2e568d9 there is a bug where unpiping a stream
from a readable stream that has `_readableState.pipesCount > 1`
will cause it to remove the first stream in the
`_.readableState.pipes` array no matter where in the list the
`dest` stream was.

Ref: https://github.com/nodejs/node/pull/9553
PR-URL: https://github.com/nodejs/node/pull/9171
Reviewed-By: Evan Lucas <evanlucas@me.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Myles Borins <myles.borins@gmail.com>

8 years ago

2 Commits (919e0cb8f26dc82faeb2f3485ef6cddbb52d0226)