lukechilds/node - node - Gitea: Git with a cup of tea

12212 Commits

131 Branches

446 Tags

325 MiB

Tree: 928166c4a8

Commit Graph

Author	SHA1	Message	Date
Brendan Ashworth	083c421b5c	benchmark: remove extra spacing in http options This commit removes the benchmark spacing modification in `client-request-body.js` and `end-vs-write-end.js` which adds two spaces to the end of some variables to make sure the lines line up. The reason behind this is that its totally pointless (the lines don't actually line up with it) and it disallows you to parse the output with a tool like awk, or at least makes it a lot harder. PR-URL: https://github.com/iojs/io.js/pull/650 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>	10 years ago
Timothy J Fontaine	bfc823de90	benchmark: update to use new wrk	11 years ago
isaacs	d62cf59dc1	http: Don't hot-path end() for large buffers The benefits of the hot-path optimization below start to fall off when the buffer size gets up near 128KB, because the cost of the copy is more than the cost of the extra write() call. Switch to the write/end method at that point. Heuristics and magic numbers are awful, but slow http responses are worse. Fix #4975	12 years ago

Author

SHA1

Message

Date

Brendan Ashworth

083c421b5c

benchmark: remove extra spacing in http options

This commit removes the benchmark spacing modification in
`client-request-body.js` and `end-vs-write-end.js` which adds two spaces
to the end of some variables to make sure the lines line up.

The reason behind this is that its totally pointless (the lines don't
actually line up with it) and it disallows you to parse the output with
a tool like awk, or at least makes it a lot harder.

PR-URL: https://github.com/iojs/io.js/pull/650
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>

10 years ago

Timothy J Fontaine

bfc823de90

benchmark: update to use new wrk

11 years ago

isaacs

d62cf59dc1

http: Don't hot-path end() for large buffers

The benefits of the hot-path optimization below start to fall off when
the buffer size gets up near 128KB, because the cost of the copy is more
than the cost of the extra write() call.  Switch to the write/end method
at that point.

Heuristics and magic numbers are awful, but slow http responses are
worse.

Fix #4975

12 years ago

3 Commits (928166c4a8a7c630af047eb33bbf1bab9353c71b)