lukechilds/node - node - Gitea: Git with a cup of tea

Author	SHA1	Message	Date
isaacs	993bb93e0a	streams: Don't emit 'end' until read() past EOF This prevents the following sort of thing from being confusing: ```javascript stream.on('data', function() { console.error('got data'); }); stream.pause(); // stop reading // turns out no data is available stream.push(null); // Hand the stream to someone else, who does stuff... setTimeout(function() { // too late! 'end' is already emitted! stream.on('end', function() { console.error('got end'); }); }); ``` With this change, the `end` event is not emitted until you call `read()` past the EOF null. So, a paused stream will not swallow the `end` event and emit it before you `resume()` the stream.	11 years ago
isaacs	0f8de5e1f9	stream: Simplify flowing, passive data listening Closes #5860 In streams2, there is an "old mode" for compatibility. Once switched into this mode, there is no going back. With this change, there is a "flowing mode" and a "paused mode". If you add a data listener, then this will start the flow of data. However, hitting the `pause()` method will switch back into a non-flowing mode, where the `read()` method will pull data out. Every time `read()` returns a data chunk, it also emits a `data` event. In this way, a passive data listener can be added, and the stream passed off to some other reader, for use with progress bars and the like. There is no API change beyond this added flexibility.	11 years ago
Jeff Barczewski	26ca7d73ca	stream: objectMode transform should allow falsey values If a transform stream has objectMode = true, it should allow falsey values other than (null) like 0, false, ''. null is reserved to indicate stream eof but other falsey values should flow through properly.	12 years ago
Gil Pedersen	c3aae9cf95	stream: Fix stall in Transform under very specific conditions The stall is exposed in the test, though the test itself asserts before it stalls. The test is constructed to replicate the stalling state of a complex Passthrough usecase since I was not able to reliable trigger the stall. Some of the preconditions for triggering the stall are: * rs.length >= rs.highWaterMark * !rs.needReadable * _transform() handler that can return empty transforms * multiple sync write() calls Combined this can trigger a case where rs.reading is not cleared when further progress requires this. The fix is to always clear rs.reading.	12 years ago
isaacs	08f5db112f	test: Make stream2-transform less timing-dependent	12 years ago
isaacs	312289b791	stream: Use class for write buffer entries	12 years ago
isaacs	426b4c6258	stream: _write takes an encoding argument This vastly reduces the overhead of decodeStrings:false streams, such as net and http.	12 years ago
isaacs	cd68d86c32	stream: Remove output function from _transform Just use stream.push(outputChunk) instead.	12 years ago
isaacs	3b2e9d2648	stream: remove lowWaterMark feature It seems like a good idea on the face of it, but lowWaterMarks are actually not useful, and in practice should always be set to zero. It would be worthwhile for writers if we actually did some kind of writev() type of thing, but actually this just delays calling write() and the overhead of doing a bunch of Buffer copies is not worth the slight benefit of calling write() fewer times.	12 years ago
isaacs	e26622bd18	stream: Correct Transform class backpressure The refactor in `b43e544140` to use stream.push() in Transform inadvertently caused it to immediately consume all the written data, regardless of whether or not the readable side was being consumed. Only pull data through the _transform() process when the readable side is being consumed. Fix #4667	12 years ago
isaacs	6e05faa3d0	test: Add transform objectMode test	12 years ago
Raynos	444bbd4fa7	streams: Support objects other than Buffers We detect for non-string and non-buffer values in onread and turn the stream into an "objectMode" stream. If we are in "objectMode" mode then howMuchToRead will always return 1, state.length will always have 1 appended to it when there is a new item and fromList always takes the first value from the list. This means that for object streams, the n in read(n) is ignored and read() will always return a single value Fixed a bug with unpipe where the pipe would break because the flowing state was not reset to false. Fixed a bug with sync cb(null, null) in _read which would forget to end the readable stream	12 years ago
isaacs	b43e544140	stream: Use push() for Transform._output() This also slightly changes the semantics, in that a 'readable' event may be triggered by the first write() call, even if a user has not yet called read(). This happens because the Transform _write() handler is calling read(0) to start the flow of data. Technically, the new behavior is more 'correct', since it is more in line with the semantics of the 'readable' event in other streams.	12 years ago
isaacs	c2f62d496a	test: Update stream2 transform for corrected behavior	12 years ago
isaacs	9b1b85490b	streams2: Tests of new interfaces	12 years ago