lukechilds/node - node - Gitea: Git with a cup of tea

13721 Commits

131 Branches

446 Tags

325 MiB

Tree: 962c1e1cac

Commit Graph

Author SHA1 Message Date

Author	SHA1	Message	Date
Evan Lucas	503b089dd8	net: don't throw on immediately destroyed socket Fixes regression introduced in `af249fa8a1`. With connect being deferred to the next tick, Socket.destroy could be called before connect. Socket.destroy sets _connecting to false which would cause an assertion error. Fixes: https://github.com/nodejs/io.js/issues/2250 PR-URL: https://github.com/nodejs/io.js/pull/2251 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com> Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>	10 years ago

Evan Lucas

503b089dd8

net: don't throw on immediately destroyed socket

Fixes regression introduced in af249fa8a1.

With connect being deferred to the next tick, Socket.destroy could be
called before connect. Socket.destroy sets _connecting to false which
would cause an assertion error.

Fixes: https://github.com/nodejs/io.js/issues/2250
PR-URL: https://github.com/nodejs/io.js/pull/2251
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>
Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>

10 years ago

1 Commits (962c1e1cace876b40ace6f49d8556630eaf77f9b)