lukechilds/node - node - Gitea: Git with a cup of tea

12915 Commits

131 Branches

446 Tags

325 MiB

Tree: 97eedfc57a

Commit Graph

Author	SHA1	Message	Date
Roman Reiss	81e98e9363	test: use normalize() for unicode paths OS X 10.11 changed the unicode normalization form of certain code points returned by system calls like getcwd() from NFC to NFD which made results in this test failing. The consensus of https://github.com/nodejs/node/issues/2165 is to delegate the task of unicode normalization to the user, and work will continue to document how to handle unicode in a form-sensitive file system. PR-URL: https://github.com/nodejs/node/pull/3007 Fixes: https://github.com/nodejs/node/issues/2165 Reviewed-By: Johan Bergström <bugs@bergstroem.nu> Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com> Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>	10 years ago
Sakthipriyan Vairamani	9aa6a437cd	test: use tmp directory in chdir test This patch - makes chdir test to use the tmp directory - moves the test to parallel - renames the file to test-process-chdir as chdir is in process module PR-URL: https://github.com/nodejs/node/pull/2589 Reviewed-By: Brendan Ashworth <brendan.ashworth@me.com> Reviewed-By: Rich Trott <rtrott@gmail.com>	10 years ago

Author

SHA1

Message

Date

Roman Reiss

81e98e9363

test: use normalize() for unicode paths

OS X 10.11 changed the unicode normalization form of certain code points
returned by system calls like getcwd() from NFC to NFD which made
results in this test failing.

The consensus of https://github.com/nodejs/node/issues/2165 is to delegate
the task of unicode normalization to the user, and work will continue to
document how to handle unicode in a form-sensitive file system.

PR-URL: https://github.com/nodejs/node/pull/3007
Fixes: https://github.com/nodejs/node/issues/2165
Reviewed-By: Johan Bergström <bugs@bergstroem.nu>
Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>
Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>

10 years ago

Sakthipriyan Vairamani

9aa6a437cd

test: use tmp directory in chdir test

This patch

 - makes chdir test to use the tmp directory
 - moves the test to parallel
 - renames the file to test-process-chdir as chdir is in process module

PR-URL: https://github.com/nodejs/node/pull/2589
Reviewed-By: Brendan Ashworth <brendan.ashworth@me.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>

10 years ago

2 Commits (97eedfc57a1a36cb11d20208287f4dd07aa49457)