lukechilds/node - node - Gitea: Git with a cup of tea

13770 Commits

131 Branches

446 Tags

325 MiB

Tree: 9b29cfc3a6

Commit Graph

Author SHA1 Message Date

Author	SHA1	Message	Date
Rich Trott	6a08535dd1	child_process: preserve argument type A previous fix for a `maxBuffer` bug resulted in a change to the argument type for the `data` event on `child.stdin` and `child.stdout` when using `child_process.exec()`. This fixes the `maxBuffer` bug in a way that does not have that side effect. PR-URL: https://github.com/nodejs/node/pull/7391 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Jackson Tian <shyvo1987@gmail.com> Fixes: https://github.com/nodejs/node/issues/7342 Refs: https://github.com/nodejs/node/issues/1901	9 years ago
Rich Trott	fd05b0b289	Revert "child_process: measure buffer length in bytes" This reverts commit `c9a5990a76`. PR-URL: https://github.com/nodejs/node/pull/7391 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Jackson Tian <shyvo1987@gmail.com>	9 years ago
Rich Trott	a31d3161f5	test: add test for exec() known issue PR-URL: https://github.com/nodejs/node/pull/7375 Refs: https://github.com/nodejs/node/issues/7342 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Santiago Gimeno <santiago.gimeno@gmail.com>	9 years ago

Rich Trott

6a08535dd1

child_process: preserve argument type

A previous fix for a `maxBuffer` bug resulted in a change to the
argument type for the `data` event on `child.stdin` and `child.stdout`
when using `child_process.exec()`.

This fixes the `maxBuffer` bug in a way that does not have that side
effect.

PR-URL: https://github.com/nodejs/node/pull/7391
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Jackson Tian <shyvo1987@gmail.com>
Fixes: https://github.com/nodejs/node/issues/7342
Refs: https://github.com/nodejs/node/issues/1901

9 years ago

Rich Trott

fd05b0b289

Revert "child_process: measure buffer length in bytes"

This reverts commit c9a5990a76.

PR-URL: https://github.com/nodejs/node/pull/7391
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Jackson Tian <shyvo1987@gmail.com>

9 years ago

Rich Trott

a31d3161f5

test: add test for exec() known issue

PR-URL: https://github.com/nodejs/node/pull/7375
Refs: https://github.com/nodejs/node/issues/7342
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Santiago Gimeno <santiago.gimeno@gmail.com>

9 years ago

1 Commits (9b29cfc3a6ef86a9dd3fdf7511367c3ea6e77b25)