lukechilds/node - node - Gitea: Git with a cup of tea

14244 Commits

131 Branches

446 Tags

325 MiB

Tree: 9c9d422433

Commit Graph

Author	SHA1	Message	Date
cjihrig	8cba3b2f72	cluster: guard against undefined message handlers cluster's internal message handling includes a cache of callback functions. Once the message for that callback is received, it is removed from the cache. If, for any reason, the same message ID is processed twice, the callback will be missing from the cache and cluster will try to call undefined as a function. This commit guards against this scenario. Refs: https://github.com/nodejs/node/issues/6561 PR-URL: https://github.com/nodejs/node/pull/6902 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Santiago Gimeno <santiago.gimeno@gmail.com>	9 years ago

Author

SHA1

Message

Date

cjihrig

8cba3b2f72

cluster: guard against undefined message handlers

cluster's internal message handling includes a cache of callback
functions. Once the message for that callback is received, it is
removed from the cache. If, for any reason, the same message ID
is processed twice, the callback will be missing from the cache
and cluster will try to call undefined as a function. This commit
guards against this scenario.

Refs: https://github.com/nodejs/node/issues/6561
PR-URL: https://github.com/nodejs/node/pull/6902
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Santiago Gimeno <santiago.gimeno@gmail.com>

9 years ago

1 Commits (9c9d422433642df6455999a458af122e5fcc2c13)