lukechilds/node - node - Gitea: Git with a cup of tea

Author	SHA1	Message	Date
Jonathan Reem	7fa4a9697d	stream: only end reading on null, not undefined The [Stream documentation for .push](http://nodejs.org/api/stream.html#stream_readable_push_chunk_encoding) explicitly states multiple times that null is a special cased value that indicates the end of a stream. It is confusing and undocumented that undefined also ends the stream, even though in object mode there is a distinct and important difference. The docs for Object-Mode also explicitly mention null as the only special cased value, making no mention of undefined. Signed-off-by: Fedor Indutny <fedor@indutny.com>	11 years ago
isaacs	88644eaa2d	stream: There is no _read cb, there is only push This makes it so that `stream.push(chunk)` is the only way to signal the end of reading, removing the confusing disparity between the callback-style _read method, and the fact that most real-world streams do not have a 1:1 corollation between the "please give me data" event, and the actual arrival of a chunk of data. It is still possible, of course, to implement a `CallbackReadable` on top of this. Simply provide a method like this as the callback: function readCallback(er, chunk) { if (er) stream.emit('error', er); else stream.push(chunk); } However, only fs streams actually would behave in this way, so it makes not a lot of sense to make TCP, TLS, HTTP, and all the rest have to bend into this uncomfortable paradigm.	12 years ago
isaacs	27fafd4648	stream: Do not call endReadable on a non-empty stream Say that a stream's current read queue has 101 bytes in it, and the underlying resource has ended (ie, reached EOF). If you do something like this: stream.read(100); // leave a byte behind stream.read(0); // read(0) for some reason then the read(0) will get 0 from the howMuchToRead function. Since the stream was ended, this was incorrectly treating the 0 as a "there is no more in the buffer", and emitting 'end' before that last byte was read. Why have the read(0) in the first place? We do this in some cases to trigger the last few bytes of a net socket (such as a child process's stdio pipes). This was causing issues when piping a `git archive` job to a file: the resulting tarball was incomplete, because it occasionally was not getting the last chunk.	12 years ago
Ben Noordhuis	916832cd2c	test: fix function name typo It doesn't affect the semantics of the test because it checks if that particular bit of code throws an exception. It does, only it's a SyntaxError.	13 years ago
Timothy J Fontaine	320ae691d8	timers: make unref'd timeouts execute in a domain	13 years ago
Igor Zinkovsky	0dcc43316f	don't crash when queued write fails	13 years ago
isaacs	0cdf85e28d	Lint all the JavaScripts.	13 years ago
Ben Noordhuis	b261e37a34	test: ensure callback is executed	13 years ago
Ju-yeong Park	5976d58796	net: raise exception when the socket is closed	13 years ago
Ryan Dahl	850609ea2d	Remove separation of libuv tests	13 years ago
Ryan Dahl	4e1d6fca8e	Mark tests which are broken in libuv	14 years ago
Felix Geisendörfer	09ee29318f	Emit 'close' after all connections have closed Fixes #1383	14 years ago
Ryan Dahl	55048cdf79	Update copyright headers	14 years ago
koichik	113b1e6e0c	Fix GH-746 process.stdin.destroy() breaks http server	14 years ago