lukechilds/node - node - Gitea: Git with a cup of tea

16397 Commits

131 Branches

446 Tags

325 MiB

Tree: 9dac165160

Commit Graph

Author	SHA1	Message	Date
cjihrig	71f541411d	test: verify shell option internals This commit adds code coverage to the internals associated with the child_process shell option. This achieves the following: - Increased code coverage, which is currently only reported for Unix. - Ensures that all six code paths are covered, including the three Windows variations, and Android which is not tested at all on CI. PR-URL: https://github.com/nodejs/node/pull/10924 Reviewed-By: Rich Trott <rtrott@gmail.com>	8 years ago
cjihrig	e5499b32cf	test: s/assert.notEqual()/assert.notStrictEqual()/ PR-URL: https://github.com/nodejs/node/pull/10541 Reviewed-By: Sam Roberts <vieuxtech@gmail.com> Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Italo A. Casas <me@italoacasas.com>	8 years ago
cjihrig	c3bb4b1aa5	child_process: add shell option to spawn() This commit adds a shell option, to spawn() and spawnSync(). This option allows child processes to be spawned with or without a shell. The option also allows a custom shell to be defined, for compatibility with exec()'s shell option. Fixes: https://github.com/nodejs/node/issues/1009 PR-URL: https://github.com/nodejs/node/pull/4598 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: James M Snell <jasnell@gmail.com>	9 years ago

Author

SHA1

Message

Date

cjihrig

71f541411d

test: verify shell option internals

This commit adds code coverage to the internals associated with
the child_process shell option. This achieves the following:

- Increased code coverage, which is currently only reported
for Unix.
- Ensures that all six code paths are covered, including the
three Windows variations, and Android which is not tested at
all on CI.

PR-URL: https://github.com/nodejs/node/pull/10924
Reviewed-By: Rich Trott <rtrott@gmail.com>

8 years ago

cjihrig

e5499b32cf

test: s/assert.notEqual()/assert.notStrictEqual()/

PR-URL: https://github.com/nodejs/node/pull/10541
Reviewed-By: Sam Roberts <vieuxtech@gmail.com>
Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Italo A. Casas <me@italoacasas.com>

8 years ago

cjihrig

c3bb4b1aa5

child_process: add shell option to spawn()

This commit adds a shell option, to spawn() and spawnSync(). This
option allows child processes to be spawned with or without a
shell. The option also allows a custom shell to be defined, for
compatibility with exec()'s shell option.

Fixes: https://github.com/nodejs/node/issues/1009
PR-URL: https://github.com/nodejs/node/pull/4598
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: James M Snell <jasnell@gmail.com>

9 years ago

3 Commits (9dac1651604ee44ef99672107d8ad0286583400e)