lukechilds/node - node - Gitea: Git with a cup of tea

Author	SHA1	Message	Date
Domenic Denicola	7afdba6e0b	vm, core, module: re-do vm to fix known issues As documented in #3042 and in [1], the existing vm implementation has many problems. All of these are solved by @brianmcd's [contextify][2] package. This commit uses contextify as a conceptual base and its code core to overhaul the vm module and fix its many edge cases and caveats. Functionally, this fixes #3042. In particular: - A context is now indistinguishable from the object it is based on (the "sandbox"). A context is simply a sandbox that has been marked by the vm module, via `vm.createContext`, with special internal information that allows scripts to be run inside of it. - Consequently, items added to the context from anywhere are immediately visible to all code that can access that context, both inside and outside the virtual machine. This commit also smooths over the API very slightly: - Parameter defaults are now uniformly triggered via `undefined`, per ES6 semantics and previous discussion at [3]. - Several undocumented and problematic features have been removed, e.g. the conflation of `vm.Script` with `vm` itself, and the fact that `Script` instances also had all static `vm` methods. The API is now exactly as documented (although arguably the existence of the `vm.Script` export is not yet documented, just the `Script` class itself). In terms of implementation, this replaces node_script.cc with node_contextify.cc, which is derived originally from [4] (see [5]) but has since undergone extensive modifications and iterations to expose the most useful C++ API and use the coding conventions and utilities of Node core. The bindings exposed by `process.binding('contextify')` (node_contextify.cc) replace those formerly exposed by `process.binding('evals')` (node_script.cc). They are: - ContextifyScript(code, [filename]), with methods: - runInThisContext() - runInContext(sandbox, [timeout]) - makeContext(sandbox) From this, the vm.js file builds the entire documented vm module API. node.js and module.js were modified to use this new native binding, or the vm module itself where possible. This introduces an extra line or two into the stack traces of module compilation (and thus into most stack traces), explaining the changed tests. The tests were also updated slightly, with all vm-related simple tests consolidated as test/simple/test-vm-* (some of them were formerly test/simple/test-script-*). At the same time they switched from `common.debug` to `console.error` and were updated to use `assert.throws` instead of rolling their own error-testing methods. New tests were also added, of course, demonstrating the new capabilities and fixes. [1]: http://nodejs.org/docs/v0.10.16/api/vm.html#vm_caveats [2]: https://github.com/brianmcd/contextify [3]: https://github.com/joyent/node/issues/5323#issuecomment-20250726 [4]: `bf123f3ef9/src/contextify.cc` [5]: https://gist.github.com/domenic/6068120	11 years ago
isaacs	a811a4a130	Fix #3058 querystring: Fix incorrect handling of empty keys	13 years ago
isaacs	0cdf85e28d	Lint all the JavaScripts.	13 years ago
Fedor Indutny	23de33968f	querystring: fix maxKeys = 0 is ignored	13 years ago
Fedor Indutny	8a98c2f1d8	http, querystring: added limits to prevent DoS	13 years ago
Colton Baker	87286cc737	Fixed a lot of jslint errors. Fixes #1831	13 years ago
isaacs	e06ce7562c	Fix #1707 hasOwnProperty usage If hasOwnProperty is overridden, then calling `obj.hasOwnProperty(prop)` can fail. Any time a dictionary of user-generated items is built, we cannot rely on hasOwnProperty being safe, so must call it from the Object.prototype explicitly.	13 years ago
isaacs	b3af074a02	Add querystring test for hasOwnProperty usage	13 years ago
isaacs	ac4791393e	Fix #1497 querystring: Replace 'in' test with 'hasOwnProperty'	13 years ago
isaacs	3210809d0a	Fix #1497 querystring: Replace 'in' test with 'hasOwnProperty'	13 years ago
Ryan Dahl	55048cdf79	Update copyright headers	14 years ago
Oleg Efimov	0ce9cbab29	GJSLint continue	14 years ago
Ryan Dahl	a0159b4b29	Fix global leaks	14 years ago
Ryan Dahl	2a750bffcc	Add tests for querystring.unescapeBuffer	14 years ago
Ryan Dahl	8b1082825c	Rename require('javascript') to require('vm')	14 years ago
Ryan Dahl	d787a444c5	Use require('javascript') instead of process.binding('evals')	14 years ago
Peter Griess	422d3c93bc	Get rid of PHP/Rails style parameter munging. - Handle only the most basic of query string parsing and construction. Leave the rest (e.g. Rails/PHP behaviors) to modules higher up the stack, like Express.	14 years ago
cloudhead	fe3e419687	querystring.parse: handle undefined value properly	14 years ago
Micheil Smith	299671b731	querystring: Removing typecasting of numeric strings to numbers The tests did not accurately test for a strict equality, meaning that the number == to the string.	14 years ago
Jan Kassens	f18d9d8466	querystring.js: JSLint warnings fixed	14 years ago
Jan Kassens	bb2acd5e75	querystring.stringify is now more solid * handles NaN and Infinity * works with arrays from other contexts	14 years ago
Ryan Dahl	9fd5e3c89c	Update tests to work with module contexts	15 years ago
Dmitry Baranovskiy	f8ca6b383c	Rewrote QueryString.parse to make it smaller and more effective. Also added ability to parse foo.bar=4 equal to foo[bar]=4 Added tests for this as well	15 years ago
isaacs	4ce100fa62	A replacement for decodeURIComponent that doesn't throw. And add a few more tests.	15 years ago
Thomas Lee	a63ce5cd72	Allow callers to disable PHP/Rails style parameter mungeing in querystring.stringify	15 years ago
isaacs	5861db8a69	Remove process.mixin dependency from all tests.	15 years ago
Ryan Dahl	b9cd3363ef	Bugfix in querystring	15 years ago
arlolra	04fac19822	Split tests.	15 years ago
isaacs	7ff04c1f86	Add URL and QueryString modules, and tests for each. Also, make a slight change from original on url-module to put the spacePattern into the function. On closer inspection, it turns out that the nonlocal-var cost is higher than the compiling-a-regexp cost. Also, documentation.	15 years ago