lukechilds/node - node - Gitea: Git with a cup of tea

Tree: a5f3b6fa7c

Author	SHA1	Message	Date
Rich Trott	995423e790	benchmark: terminate child process on Windows test-benchmark-child-process failures reveal that child-process-exec-stdout benchmark sometimes leaves around a stray yes.exe process. Add code to terminate the process. PR-URL: https://github.com/nodejs/node/pull/12658 Ref: https://github.com/nodejs/node/issues/12560 Reviewed-By: Refael Ackermann <refack@gmail.com> Reviewed-By: Bartosz Sosnowski <bartosz@janeasystems.com> Reviewed-By: James M Snell <jasnell@gmail.com>	8 years ago
Bartosz Sosnowski	882f8b3d6c	benchmark: use 'yes' instead of echo in a loop This changes child-process-exec-stdout benchmark to use 'yes' instead of echo in a while loop. This makes this benchmark consistent with child-process-read which already uses `yes` and allows this benchmark to be executed on Windows. Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> PR-URL: https://github.com/nodejs/node/pull/8721	9 years ago
Bartosz Sosnowski	27ed7fc56c	benchmark: fix child-process-exec-stdout on win This benchmark fails on Windows when trying to execute command which is more than 32k in size. This commits skips this one case when running under Windows. PR-URL: https://github.com/nodejs/node/pull/7178 Reviewed-By: Trott - Rich Trott <rtrott@gmail.com> Reviewed-By: orangemocha - Alexis Campailla <orangemocha@nodejs.org>	9 years ago
Rich Trott	0503681348	child_process: measure buffer length in bytes This change fixes a known issue where `maxBuffer` limits by characters rather than bytes. Benchmark added to confirm no performance regression occurs with this change. PR-URL: https://github.com/nodejs/node/pull/6764 Fixes: https://github.com/nodejs/node/issues/1901 Reviewed-By: Brian White <mscdex@mscdex.net>	9 years ago