lukechilds/node - node - Gitea: Git with a cup of tea

16428 Commits

131 Branches

446 Tags

325 MiB

Tree: a7b51af049

Commit Graph

Author SHA1 Message Date

Author	SHA1	Message	Date
Rich Trott	898276b1b4	test: simplify output handling in repl tests Replace .map() + .replace().trim() with a single .replace(). PR-URL: https://github.com/nodejs/node/pull/11124 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Yuta Hiroto <hello@about-hiroppy.com> Reviewed-By: Italo A. Casas <me@italoacasas.com>	8 years ago
cjihrig	2e05e65916	test: add known issue test for #7788 `15157c3c3d` changed the CLI REPL to default to useGlobal: false by default. This caused the regression seen in https://github.com/nodejs/node/issues/7788. This commit adds a known issue test while a proper resolution is determined. Refs: https://github.com/nodejs/node/pull/5703 Refs: https://github.com/nodejs/node/issues/7788 PR-URL: https://github.com/nodejs/node/pull/7793 Reviewed-By: Rich Trott <rtrott@gmail.com>	9 years ago

Rich Trott

898276b1b4

test: simplify output handling in repl tests

Replace .map() + .replace().trim() with a single .replace().

PR-URL: https://github.com/nodejs/node/pull/11124
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Yuta Hiroto <hello@about-hiroppy.com>
Reviewed-By: Italo A. Casas <me@italoacasas.com>

8 years ago

cjihrig

2e05e65916

test: add known issue test for #7788

15157c3c3d changed the CLI REPL
to default to useGlobal: false by default. This caused the
regression seen in https://github.com/nodejs/node/issues/7788.
This commit adds a known issue test while a proper resolution
is determined.

Refs: https://github.com/nodejs/node/pull/5703
Refs: https://github.com/nodejs/node/issues/7788
PR-URL: https://github.com/nodejs/node/pull/7793
Reviewed-By: Rich Trott <rtrott@gmail.com>

9 years ago

2 Commits (a7b51af049d25e09fb0e38b58662bb94eff52c66)