lukechilds/node - node - Gitea: Git with a cup of tea

18624 Commits

131 Branches

446 Tags

325 MiB

Tree: a7dccd040d

Commit Graph

Author	SHA1	Message	Date
Trevor Norris	64688d8e3a	async_wrap: return undefined if domain is disposed v8::MaybeLocal::ToLocalChecked() will abort on an empty handle. AsyncWrap::MakeCallback returns an empty handle if the domain is disposed, but this should not cause the process to abort. So instead return v8::Undefined() and allow the error to be handled normally. PR-URL: https://github.com/nodejs/node/pull/14722 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Refael Ackermann <refack@gmail.com>	8 years ago

Author

SHA1

Message

Date

Trevor Norris

64688d8e3a

async_wrap: return undefined if domain is disposed

v8::MaybeLocal::ToLocalChecked() will abort on an empty handle.
AsyncWrap::MakeCallback returns an empty handle if the domain is
disposed, but this should not cause the process to abort. So instead
return v8::Undefined() and allow the error to be handled normally.

PR-URL: https://github.com/nodejs/node/pull/14722
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Refael Ackermann <refack@gmail.com>

8 years ago

1 Commits (a7dccd040d72ce7de61d9160ec031420c52a49d4)