lukechilds/node - node - Gitea: Git with a cup of tea

17608 Commits

131 Branches

446 Tags

325 MiB

Tree: a86323dc64

Commit Graph

Author	SHA1	Message	Date
Vse Mozhet Byt	8b76c3e60c	test: reduce string concatenations PR-URL: https://github.com/nodejs/node/pull/12735 Refs: https://github.com/nodejs/node/pull/12455 Reviewed-By: Refael Ackermann <refack@gmail.com> Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>	8 years ago
Luca Maraschi	eed87b1637	fs: (+/-)Infinity and NaN invalid unixtimestamp Infinity and NaN are currently considered valid input when generating a unix time stamp but are defaulted arbitrarly to Date.now()/1000. This PR removes this behaviour and throw an exception like all the other invalid input types. PR-URL: https://github.com/nodejs/node/pull/11919 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>	8 years ago
Luca Maraschi	6aed32c579	test: add tests for unixtimestamp generation This test checks for the different input types for the generation of UNIX timestamps in the fs module. PR-URL: https://github.com/nodejs/node/pull/11886 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>	8 years ago

Author

SHA1

Message

Date

Vse Mozhet Byt

8b76c3e60c

test: reduce string concatenations

PR-URL: https://github.com/nodejs/node/pull/12735
Refs: https://github.com/nodejs/node/pull/12455
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>

8 years ago

Luca Maraschi

eed87b1637

fs: (+/-)Infinity and NaN invalid unixtimestamp

Infinity and NaN are currently considered valid input when generating a
unix time stamp but are defaulted arbitrarly to Date.now()/1000. This
PR removes this behaviour and throw an exception like all the other
invalid input types.

PR-URL: https://github.com/nodejs/node/pull/11919
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>

8 years ago

Luca Maraschi

6aed32c579

test: add tests for unixtimestamp generation

This test checks for the different input types for the generation
of UNIX timestamps in the fs module.

PR-URL: https://github.com/nodejs/node/pull/11886
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>

8 years ago

3 Commits (a86323dc647d9689af5ff0838b20b440d0abb986)