lukechilds/node - node - Gitea: Git with a cup of tea

16036 Commits

131 Branches

446 Tags

325 MiB

Tree: aa9815081d

Commit Graph

Author	SHA1	Message	Date
Brian White	e397e6f94a	buffer: improve compare() performance PR-URL: https://github.com/nodejs/node/pull/10927 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: James M Snell <jasnell@gmail.com>	8 years ago
Rich Trott	ffdc046e5c	benchmark: add benchmark for buf.compare() There is a benchmark for the class method `Buffer.compare()` but not for the instance method `buf.compare()`. This adds that benchmark. I used this to confirm a performance regression in an implementation I was considering. While the implementation was a bust, it does seem like the benchmark is worthwhile. The benchmark is nearly identical to the existing `Buffer.compare()` benchmark except, of course, that it calls `buf.compare()` instead. PR-URL: https://github.com/nodejs/node/pull/5441 Reviewed-By: Brian White <mscdex@mscdex.net> Reviewed-By: Evan Lucas <evanlucas@me.com>	9 years ago

Author

SHA1

Message

Date

Brian White

e397e6f94a

buffer: improve compare() performance

PR-URL: https://github.com/nodejs/node/pull/10927
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: James M Snell <jasnell@gmail.com>

8 years ago

Rich Trott

ffdc046e5c

benchmark: add benchmark for buf.compare()

There is a benchmark for the class method `Buffer.compare()` but not for
the instance method `buf.compare()`. This adds that benchmark.

I used this to confirm a performance regression in an implementation I
was considering. While the implementation was a bust, it does seem like
the benchmark is worthwhile.

The benchmark is nearly identical to the existing `Buffer.compare()`
benchmark except, of course, that it calls `buf.compare()` instead.

PR-URL: https://github.com/nodejs/node/pull/5441
Reviewed-By: Brian White <mscdex@mscdex.net>
Reviewed-By: Evan Lucas <evanlucas@me.com>

9 years ago

2 Commits (aa9815081d6374f7380bdbd6e8998a044f37d033)