lukechilds/node - node - Gitea: Git with a cup of tea

10252 Commits

131 Branches

446 Tags

325 MiB

Tree: ac2857b12c

Commit Graph

Author	SHA1	Message	Date
Trevor Norris	81a9739108	node,async-wrap: verify domain enter/exit are set The REPL global object lazy loads modules by placing getters for each. This causes MakeDomainCallback() to be run if a native module is loaded from the REPL, but if the domain module hasn't been loaded then there are no enter/exit callbacks to be called. Causing an assert() to fail. Fix the issue by conditionally running the callback instead of asserting it is available. Also add "addon" test to verify the fix. Fixes: #8231 Signed-off-by: Trevor Norris <trev.norris@gmail.com>	11 years ago

Author

SHA1

Message

Date

Trevor Norris

81a9739108

node,async-wrap: verify domain enter/exit are set

The REPL global object lazy loads modules by placing getters for each.
This causes MakeDomainCallback() to be run if a native module is loaded
from the REPL, but if the domain module hasn't been loaded then there
are no enter/exit callbacks to be called. Causing an assert() to fail.

Fix the issue by conditionally running the callback instead of asserting
it is available. Also add "addon" test to verify the fix.

Fixes: #8231
Signed-off-by: Trevor Norris <trev.norris@gmail.com>

11 years ago

1 Commits (ac2857b12cd819b68405b15c3f8e95e48bcc32d8)