lukechilds/node - node - Gitea: Git with a cup of tea

16391 Commits

131 Branches

446 Tags

325 MiB

Tree: ac400a7b09

Commit Graph

Author SHA1 Message Date

Author	SHA1	Message	Date
Zahidul Islam	3cce18104d	test: add mustCall in test-timers-clearImmediate PR-URL: https://github.com/nodejs/node/pull/12598 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>	8 years ago
Gibson Fahnestock	db61c952de	test: use eslint to fix var->const/let Manually fix issues that eslint --fix couldn't do automatically. Backport-PR-URL: https://github.com/nodejs/node/pull/11775 PR-URL: https://github.com/nodejs/node/pull/10685 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Roman Reiss <me@silverwind.io>	8 years ago
Brian White	7171bd6311	timers: fix regression with clearImmediate() This commit fixes a regression introduced in `0ed8839a27` that caused additional queued immediate callbacks to be ignored if `clearImmediate(immediate)` was called within the callback for `immediate`. PR-URL: https://github.com/nodejs/node/pull/9086 Fixes: https://github.com/nodejs/node/issues/9084 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Evan Lucas <evanlucas@me.com>	8 years ago

Zahidul Islam

3cce18104d

test: add mustCall in test-timers-clearImmediate

PR-URL: https://github.com/nodejs/node/pull/12598
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>

8 years ago

Gibson Fahnestock

db61c952de

test: use eslint to fix var->const/let

Manually fix issues that eslint --fix couldn't do automatically.

Backport-PR-URL: https://github.com/nodejs/node/pull/11775
PR-URL: https://github.com/nodejs/node/pull/10685
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Roman Reiss <me@silverwind.io>

8 years ago

Brian White

7171bd6311

timers: fix regression with clearImmediate()

This commit fixes a regression introduced in 0ed8839a27 that caused
additional queued immediate callbacks to be ignored if
`clearImmediate(immediate)` was called within the callback for
`immediate`.

PR-URL: https://github.com/nodejs/node/pull/9086
Fixes: https://github.com/nodejs/node/issues/9084
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Evan Lucas <evanlucas@me.com>

8 years ago

3 Commits (ac400a7b09d35d5191cdc5624ce3bac0b3357c1a)