lukechilds/node - node - Gitea: Git with a cup of tea

18854 Commits

131 Branches

446 Tags

325 MiB

Tree: b1c8f15c5f

Commit Graph

Author SHA1 Message Date

Author	SHA1	Message	Date
Franziska Hinkelmann	dd8982dc74	deps: cherry-pick 09de996 from V8 upstream Original commit message: [debugger] fix switch block source positions. The switch statement itself is part of the switch block. However, the source position of the statement is outside of the block. This leads to confusion for the debugger, if the switch block pushes a block context: the current context is a block context, but the scope analysis based on the current source position tells the debugger that we should be outside the scope, so we should have the function context. R=marja@chromium.org BUG=v8:6085 Review-Url: https://codereview.chromium.org/2744213003 Cr-Commit-Position: refs/heads/master@{#43744} Committed: `09de9969cc` Fixes: https://github.com/nodejs/node/issues/11746 PR-URL: https://github.com/nodejs/node/pull/11905 Fixes: https://github.com/nodejs/node/issues/11746 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Ali Ijaz Sheikh <ofrobots@google.com>	8 years ago

Franziska Hinkelmann

dd8982dc74

deps: cherry-pick 09de996 from V8 upstream

Original commit message:
  [debugger] fix switch block source positions.

  The switch statement itself is part of the switch block.
  However, the source position of the statement is outside of
  the block. This leads to confusion for the debugger, if the
  switch block pushes a block context: the current context is
  a block context, but the scope analysis based on the current
  source position tells the debugger that we should be outside
  the scope, so we should have the function context.

  R=marja@chromium.org
  BUG=v8:6085
  Review-Url: https://codereview.chromium.org/2744213003
  Cr-Commit-Position: refs/heads/master@{#43744}
  Committed: 09de9969cc

Fixes: https://github.com/nodejs/node/issues/11746
PR-URL: https://github.com/nodejs/node/pull/11905
Fixes: https://github.com/nodejs/node/issues/11746
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Ali Ijaz Sheikh <ofrobots@google.com>

8 years ago

1 Commits (b1c8f15c5f169e021f7c46eb7b219de95fe97603)