lukechilds/node - node - Gitea: Git with a cup of tea

18878 Commits

131 Branches

446 Tags

325 MiB

Tree: b210d61869

Commit Graph

Author	SHA1	Message	Date
Anatoli Papirovski	de51717c3e	test: fix flaky test-http2-session-timeout Increase server timeout, reduce frequency of calls and unbind timeout after runs are done in order to avoid race conditions. Temporarily moved to sequential. Fixes: https://github.com/nodejs/node/issues/15326 PR-URL: https://github.com/nodejs/node/pull/15338 Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Yuta Hiroto <hello@about-hiroppy.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de>	8 years ago
Anatoli Papirovski	46133b5beb	http2: use session not socket timeout, tests Change default timeout to be tracked on the session instead of the socket, as nghttp2 manages the socket and we would need to maintain two sets of timeouts for similar purpose. Also fixes session setTimeout to work as it wasn't getting _unrefActive correctly (was called on the handle). Fixes: https://github.com/nodejs/node/issues/15158 PR-URL: https://github.com/nodejs/node/pull/15188 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com>	8 years ago

Author

SHA1

Message

Date

Anatoli Papirovski

de51717c3e

test: fix flaky test-http2-session-timeout

Increase server timeout, reduce frequency of calls and
unbind timeout after runs are done in order to avoid
race conditions. Temporarily moved to sequential.

Fixes: https://github.com/nodejs/node/issues/15326
PR-URL: https://github.com/nodejs/node/pull/15338
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Yuta Hiroto <hello@about-hiroppy.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>

8 years ago

Anatoli Papirovski

46133b5beb

http2: use session not socket timeout, tests

Change default timeout to be tracked on the session instead
of the socket, as nghttp2 manages the socket and we would
need to maintain two sets of timeouts for similar purpose.
Also fixes session setTimeout to work as it wasn't getting
_unrefActive correctly (was called on the handle).

Fixes: https://github.com/nodejs/node/issues/15158
PR-URL: https://github.com/nodejs/node/pull/15188
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>

8 years ago

1 Commits (b210d61869edb0dbe0362db6a7226dada30ef94a)