lukechilds/node - node - Gitea: Git with a cup of tea

Commit Graph

Author	SHA1	Message	Date
isaacs	e06ce7562c	Fix #1707 hasOwnProperty usage If hasOwnProperty is overridden, then calling `obj.hasOwnProperty(prop)` can fail. Any time a dictionary of user-generated items is built, we cannot rely on hasOwnProperty being safe, so must call it from the Object.prototype explicitly.	14 years ago
isaacs	98990b9779	Fix #1707 hasOwnProperty usage	14 years ago
koichik	fdbfc9ceb7	net: Socket write encoding case sensitivity Fixes #1586.	14 years ago
Nathan Rajlich	0c91a835ff	util: isRegExp() should not call toString() on its argument An overloaded toString() method may have side effects so don't call it for a simple type check. Back-port of `54b409d` to the v0.4 branch.	14 years ago
Ryan Dahl	827b9c5f1f	net: fix throw error Thanks Tobi	14 years ago
Ryan Dahl	9cd510846e	Fixes #1546 . Remove expensive debug call.	14 years ago
Ben Noordhuis	4e204f37fd	net: defer DNS lookup error events to next tick net.createConnection() creates a net.Socket object and immediately calls net.Socket.connect() on it. There are no event listeners registered yet so defer the error event to the next tick. Fixes #1202.	14 years ago
isaacs	3210809d0a	Fix #1497 querystring: Replace 'in' test with 'hasOwnProperty'	14 years ago
koichik	8b3ba47f88	Fix http.ClientRequest crashes if end() was called twice Fixes #1417. Fixes #1223.	14 years ago
koichik	d32971a8cb	Doc improvements and change argument name. Fixes #1318.	14 years ago
Trent Mick	bbf7e8ed5e	http: fix setting ServerResponse.statusCode in writeHead Fixes #1374.	14 years ago
isaacs	ddfc6b78cc	Close #1360 url: Allow _ in hostnames.	14 years ago
Reid Burke	973153d1cc	Properly respond to HEAD during end(body) hot path During write(), _hasBody is checked to make sure a body is allowed -- this is now also checked during end(body) when write() isn't used. Concise final chunk for HEAD req's res.end(data). Instead of simply clearing data, check _hasBody earlier to avoid sending cruft when chunkedEncoding is used. Fixes #1291.	14 years ago
Stefan Rusu	5b02d564c3	Fixes #1085 . The agent end event may call detachSocket() after the socket is detached and destroyed by abort(). This patch avoids that behavior.	14 years ago
Stefan Rusu	901ebed8ff	Fixes #1304 . The Connection instance may be destroyed by abort() when process.nextTick is executed.	14 years ago
koichik	5f97c9a005	Improvements AssertionError message Fixes #217.	14 years ago
Ben Noordhuis	b62ecdc5bb	Revert `3e2a2a7`. Always send a HTTP/1.1 status line to the client.	14 years ago
Yoshihiro Kikuchi	82cfdb88fa	fix an broken question. Fixes #1274.	14 years ago
Ben Noordhuis	f91988979f	Don't send a HTTP/1.1 status line to HTTP/1.0 clients. Fixes #1234.	14 years ago
Jörn Horstmann	8cecc50b9d	Fixed a typo in a comment: "realpatch" -> "realpath"	14 years ago
Ryan Dahl	efca5456b8	Fixes #877 . Don't wait for socket pool to establish connections. Thanks to Yann Biancheri for putting together an initial test.	14 years ago
Ryan Dahl	f78f654131	Revert "debugger: don't allow users to input non-valid commands" breaks 'print' command This reverts commit `37d529f818`.	14 years ago
Yoshihiro KIKUCHI	99b210d7ea	tiny fixes in tty_posix.js Close #1158 Close #1160 Close #1252	14 years ago
Ryan Dahl	d627083ed5	Fixes #1187 . Support multiple 'link' headers	14 years ago
Mathias Buus	39246f65df	Closes #1177 remove one node_modules optimization to better support certain project structures.	14 years ago
Ryan Dahl	1ba2c32135	Massage util.inherits for perf increase	14 years ago
Siddharth Mahendraker	37d529f818	debugger: don't allow users to input non-valid commands Fixes #1144.	14 years ago
Ryan Petrello	58a1d7ec30	Close #562 Close #1078 Parse file:// urls properly The file:// protocol always has a hostname; it's frequently abbreviated as an empty string, which represents 'localhost' implicitly. According to RFC 1738 (http://tools.ietf.org/html/rfc1738): A file URL takes the form: file://<host>/<path> where <host> is the fully qualified domain name of the system on which the <path> is accessible... As a special case, <host> can be the string "localhost" or the empty string; this is interpreted as 'the machine from which the URL is being interpreted'.	14 years ago
Felix Geisendörfer	2b91256c61	Fix error handling bug in stream.pipe() Problem: Since stream.pipe() is registering it's own error handlers on the source and destination stream, it needs to replicate the EventEmitter 'error' emitting semantics of throwing an error if there are no other listeners. However, there was a off-by-one error because the check for remaining listeners was done after cleanup() which means the pipe's own listener was no longer included. This would cause 'error' events on either the dest or the source to throw if there was one other error listener, and while swallowing the 'error' event if there was no other listener. Solution: I added a test demonstrating the two issues and fixed the problem by correcting the off-by-one error. Fixes #1095.	14 years ago
Ryan Dahl	70dd6d4ea3	Fix TJ's assert error Unable to reproduce but connect's "make test TESTS=test/static.test.js" does it occasionally.	14 years ago
Ryan Dahl	9c7f89bf56	CryptoStream.prototype.readyState shoudn't reference fd Fixes #1069	14 years ago
Brian White	2de0611b43	Remove unused variable Fixes #1077	14 years ago
Fedor Indutny	21724ecaec	Share SSL context between server connections Fixes #1073.	14 years ago
koichik	d4f82ea590	Fix dns.resolve() with 'PTR' throws Error: Unknown type "PTR" Fixes #1038	14 years ago
koichik	80c2fe9456	Fix event listener leak check timing Fixes #1041.	14 years ago
Felix Geisendörfer	e7ac6d8fcd	Error argument for http.ServerRequest 'close' Problem: It was not possible to detect the reason for a premature connection termination in http requests. This patch provides a new `err` argument to the 'close' event which can be inspected to differentiate between a timeout and a client actively terminating the connection. Also contains tests for this new behavior for http and https.	14 years ago
Felix Geisendörfer	1fde5f51b4	Make https 'timeout' events bubble up Also adds a test case for it.	14 years ago
isaacs	307f39ce9e	Fix a url regression The change for #954 introduced a regression that would cause the url parser to fail on special chars found in the auth segment. Fix that, and also don't create invalid urls when format() is called on an object containing an auth member containing '@' characters or delimiters.	14 years ago
Ryan Dahl	110f06578d	Agent socket errors bubble up to req only if req exists Fixes #836.	14 years ago
Marcel Laverdet	c2b5ea218c	Attempt to connect to debug process more than once The debugger would give up after only 100ms but on my system this timeout isn't enough. The startup process is now modified to try 6 times every 50ms instead. Fixes #1010.	14 years ago
Ryan Dahl	55bff5bab9	TLS: simplify logic	14 years ago
Ryan Dahl	fc8afd45c7	Fix crash in debugger	14 years ago
Ryan Dahl	75a0cf970f	cleartextstream.destroy() should destroy socket. This fixes a critical bug see in MJR's production. Very difficult to build a test case. Sometimes HTTPS server gets sockets that are hanging in a half-duplex state.	14 years ago
koichik	fcc04e67c8	Fix SlowBuffer.write() with 'ucs2' throws ReferenceError.	14 years ago
isaacs	7c6f0147df	Better stream.pipe() tracking. This commit does three things: 1. Uses an exposed counter rather than a hidden array for tracking dest streams that may have multiple inputs. This allows for significantly faster lookups, since the counter can be checked in constant time rather than searching an array for the dest object. (A proper O(1) WeakMap would be better, but that may have to wait for Harmony.) 2. Calls the 'end' event logic when there is an 'error' event on the source object (and then throws if there are no other error listeners.) This is important, because otherwise 'error' events would lead to memory leaks. 3. Clean up the style a bit. Function Declarations are not allowed within blocks in ES strict. Prefer Function Declarations to Function Expressions, because hoisting allows for more expressive ordering of logic. Downside: It adds "_pipeCount" as part of the Stream API. It'll work fine if the member is missing, but if anyone tries to use it for some other purpose, it can mess things up.	14 years ago
isaacs	bbffd9e502	Close #983 Better JSON.parse error detection Previous pattern would only catch ILLEGAL, not { or other known-but-unexpected JSON tokens.	14 years ago
Tim Baumann	6c7c4aeab6	Don't overwrite an user-specified repl.writer	14 years ago
Wade Simmons	d00739ce56	make it possible to do repl.start('', stream)	14 years ago
isaacs	90802d628d	Close #954 URL parsing/formatting corrections 1. Allow single-quotes in urls, but escape them. 2. Add comments about which RFCs we're following for guidance. 3. Handle any invalid character in the hostname portion. 4. lcase protocol and hostname portions, since they are case-insensitive.	14 years ago
Felix Geisendörfer	6c5b31bd80	Fix: Multiple pipes to the same stream were broken When creating multiple .pipe()s to the same destination stream, the first source to end would close the destination, breaking all remaining pipes. This patch fixes the problem by keeping track of all open pipes, so that we only call end on destinations that have no more sources piping to them. closes #929	14 years ago

1 2 3 4 5 ...

1044 Commits (b31d5ac639a60139a31f0fc8124210c3a7a677ab)