lukechilds/node - node - Gitea: Git with a cup of tea

Author	SHA1	Message	Date
Roman Reiss	fb8811d95e	lib,test: fix whitespace issues PR-URL: https://github.com/nodejs/io.js/pull/1971 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>	10 years ago
Roman Reiss	f29762f4dd	test: enable linting for tests Enable linting for the test directory. A number of changes was made so all tests conform the current rules used by lib and src directories. The only exception for tests is that unreachable (dead) code is allowed. test-fs-non-number-arguments-throw had to be excluded from the changes because of a weird issue on Windows CI. PR-URL: https://github.com/nodejs/io.js/pull/1721 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>	10 years ago
Brendan Ashworth	0df54303c1	test: common.js -> common This commit changes many test styles to change all references from require('./common.js'); to require('./common');. The latter is much more common, with the former only being used in 50 tests. It is just a stylistic change, and it seems that `common.js` was introduced by a rogue test and copied and pasted into the rest. Semver: patch PR-URL: https://github.com/iojs/io.js/pull/917 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>	10 years ago
isaacs	3e1b1dd4a9	Remove excessive copyright/license boilerplate The copyright and license notice is already in the LICENSE file. There is no justifiable reason to also require that it be included in every file, since the individual files are not individually distributed except as part of the entire package.	10 years ago
Ben Noordhuis	204228b57f	test: move slow tests to test/pummel/ Slowness being somewhat subjective but determined by running the test suite a few times and picking off everything that consistently clocks in at 2 seconds or more. Honorable mention for simple/test-tls-server-large-request, it often runs for 10 (!) seconds or more.	11 years ago
isaacs	689e5c9d3d	stream: return this from pause()/resume()	11 years ago
isaacs	0f8de5e1f9	stream: Simplify flowing, passive data listening Closes #5860 In streams2, there is an "old mode" for compatibility. Once switched into this mode, there is no going back. With this change, there is a "flowing mode" and a "paused mode". If you add a data listener, then this will start the flow of data. However, hitting the `pause()` method will switch back into a non-flowing mode, where the `read()` method will pull data out. Every time `read()` returns a data chunk, it also emits a `data` event. In this way, a passive data listener can be added, and the stream passed off to some other reader, for use with progress bars and the like. There is no API change beyond this added flexibility.	12 years ago
isaacs	119cbf4854	stream: Don't require read(0) to emit 'readable' event When a readable listener is added, call read(0) so that data will flow in, up to the high water mark. Otherwise, it's somewhat confusing that you have to listen for readable, and ALSO call read() (when it will certainly return null) just to get some data out of the stream. See: #4720	12 years ago
isaacs	88644eaa2d	stream: There is no _read cb, there is only push This makes it so that `stream.push(chunk)` is the only way to signal the end of reading, removing the confusing disparity between the callback-style _read method, and the fact that most real-world streams do not have a 1:1 corollation between the "please give me data" event, and the actual arrival of a chunk of data. It is still possible, of course, to implement a `CallbackReadable` on top of this. Simply provide a method like this as the callback: function readCallback(er, chunk) { if (er) stream.emit('error', er); else stream.push(chunk); } However, only fs streams actually would behave in this way, so it makes not a lot of sense to make TCP, TLS, HTTP, and all the rest have to bend into this uncomfortable paradigm.	12 years ago
isaacs	34046084c0	stream: Do not switch to objectMode implicitly Only handle objects if explicitly told to do so in the options object. Non-buffer/string chunks are an error if not already in objectMode. Close #4662	12 years ago
isaacs	27d1babaae	streams: Pre-emptively buffer readables up to the highWaterMark Also, this adds a test that guarantees that the ordering of several push() calls in a row is always preserved in synchronous readable streams	12 years ago
isaacs	3b2e9d2648	stream: remove lowWaterMark feature It seems like a good idea on the face of it, but lowWaterMarks are actually not useful, and in practice should always be set to zero. It would be worthwhile for writers if we actually did some kind of writev() type of thing, but actually this just delays calling write() and the overhead of doing a bunch of Buffer copies is not worth the slight benefit of calling write() fewer times.	12 years ago
Raynos	444bbd4fa7	streams: Support objects other than Buffers We detect for non-string and non-buffer values in onread and turn the stream into an "objectMode" stream. If we are in "objectMode" mode then howMuchToRead will always return 1, state.length will always have 1 appended to it when there is a new item and fromList always takes the first value from the list. This means that for object streams, the n in read(n) is ignored and read() will always return a single value Fixed a bug with unpipe where the pipe would break because the flowing state was not reset to false. Fixed a bug with sync cb(null, null) in _read which would forget to end the readable stream	12 years ago
isaacs	20a3c5d09c	streams2: Do not allow hwm < lwm There was previously an assert() in there, but this part of the code is so high-volume that the added cost made a measurable dent in http_simple. Just checking inline is fine, though, and prevents a lot of potential hazards.	12 years ago
isaacs	2ff499c022	streams2: Do multipipe without always using forEach The Array.forEach call is too expensive.	12 years ago
isaacs	9b1b85490b	streams2: Tests of new interfaces	12 years ago