lukechilds/node - node - Gitea: Git with a cup of tea

16674 Commits

131 Branches

446 Tags

325 MiB

Tree: b377034359

Commit Graph

Author SHA1 Message Date

Author	SHA1	Message	Date
Michaël Zasso	ca48071919	test: make test-intl-no-icu-data more robust In V8 5.6, String#toLocaleUpperCase can work even when no ICU data is loaded. Use another method to check the --icu-data-dir option pointing to an empty directory. PR-URL: https://github.com/nodejs/node/pull/10992 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>	8 years ago
Ben Noordhuis	291b599bba	src: fix --icu-data-dir= regression Commit `a8734af` ("src: make copies of startup environment variables") from two weeks ago introduced a regression in the capturing of the `--icu-data-dir=` switch: it captured the string up to the `=` instead of what comes after it. PR-URL: https://github.com/nodejs/node/pull/11255 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Sam Roberts <vieuxtech@gmail.com>	8 years ago
Ben Noordhuis	46345b9374	src: make --icu-data-dir= switch testable Move some code around so we can properly test whether the switch actually does anything. PR-URL: https://github.com/nodejs/node/pull/11255 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Sam Roberts <vieuxtech@gmail.com>	8 years ago

Michaël Zasso

ca48071919

test: make test-intl-no-icu-data more robust

In V8 5.6, String#toLocaleUpperCase can work even when no ICU data is
loaded. Use another method to check the --icu-data-dir option pointing
to an empty directory.

PR-URL: https://github.com/nodejs/node/pull/10992
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>

8 years ago

Ben Noordhuis

291b599bba

src: fix --icu-data-dir= regression

Commit a8734af ("src: make copies of startup environment variables")
from two weeks ago introduced a regression in the capturing of the
`--icu-data-dir=` switch: it captured the string up to the `=` instead
of what comes after it.

PR-URL: https://github.com/nodejs/node/pull/11255
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Sam Roberts <vieuxtech@gmail.com>

8 years ago

Ben Noordhuis

46345b9374

src: make --icu-data-dir= switch testable

Move some code around so we can properly test whether the switch
actually does anything.

PR-URL: https://github.com/nodejs/node/pull/11255
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Sam Roberts <vieuxtech@gmail.com>

8 years ago

3 Commits (b377034359aa07f2ba83a5a0c9f859418cb80e39)