lukechilds/node - node - Gitea: Git with a cup of tea

17290 Commits

131 Branches

446 Tags

325 MiB

Tree: b45abfda5f

Commit Graph

Author	SHA1	Message	Date
Jeremiah Senkpiel	65cd2a0f96	test: increase timeouts on some unref timers tests Fix: https://github.com/nodejs/node/issues/5351 Refs: https://github.com/nodejs/node/pull/4561 PR-URL: https://github.com/nodejs/node/pull/5352 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Minwoo Jung <jmwsoft@gmail.com>	9 years ago
Jeremiah Senkpiel	049b3a3ae2	timers: minor _unrefActive fixes and improvements This commit addresses most of the review comments in https://github.com/nodejs/node/pull/2540, which are kept in this separate commit so as to better preserve the prior two patches as they landed in 0.12. This commit: - Fixes a bug with unrefActive timers and disposed domains. - Fixes a bug with unrolling an unrefActive timer from another. - Adds a test for both above bugs. - Improves check logic, making it stricter, simpler, or both. - Optimizes nicer with a smaller, separate function for the try/catch. Fixes: https://github.com/nodejs/node-convergence-archive/issues/23 Ref: https://github.com/nodejs/node/issues/268 PR-URL: https://github.com/nodejs/node/pull/2540 Reviewed-By: bnoordhuis - Ben Noordhuis <info@bnoordhuis.nl>	10 years ago

Author

SHA1

Message

Date

Jeremiah Senkpiel

65cd2a0f96

test: increase timeouts on some unref timers tests

Fix: https://github.com/nodejs/node/issues/5351
Refs: https://github.com/nodejs/node/pull/4561
PR-URL: https://github.com/nodejs/node/pull/5352

Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Minwoo Jung <jmwsoft@gmail.com>

9 years ago

Jeremiah Senkpiel

049b3a3ae2

timers: minor _unrefActive fixes and improvements

This commit addresses most of the review comments in
https://github.com/nodejs/node/pull/2540, which are kept in this
separate commit so as to better preserve the prior two patches as they
landed in 0.12.

This commit:
- Fixes a bug with unrefActive timers and disposed domains.
- Fixes a bug with unrolling an unrefActive timer from another.
- Adds a test for both above bugs.
- Improves check logic, making it stricter, simpler, or both.
- Optimizes nicer with a smaller, separate function for the try/catch.

Fixes: https://github.com/nodejs/node-convergence-archive/issues/23
Ref: https://github.com/nodejs/node/issues/268
PR-URL: https://github.com/nodejs/node/pull/2540
Reviewed-By: bnoordhuis - Ben Noordhuis <info@bnoordhuis.nl>

10 years ago

2 Commits (b45abfda5f34bacbf2dc5f55fa95dd9620031cc7)