lukechilds/node - node - Gitea: Git with a cup of tea

10681 Commits

131 Branches

446 Tags

325 MiB

Tree: b48639befd

Commit Graph

Author	SHA1	Message	Date
Michael Dawson	5dd5ce75d7	test: Env variable to specify directory for pipes At the uv layer pipes are connected with uv_pipe_connect. The current spec for this method indicates that the maximum length is limited to the size of length of sizeof(sockaddr_un.sun_path), typically between 92 and 108 bytes. Anything longer than that just gets truncated. The simple testsuite currently creates pipes in directories under the directory where node was built. In our jenkins jobs this sometimes ends up being a deep enough path that the path for the pipes is getting truncated. The result is that tests using pipes fail with errors that don't make it obvious what the problem is. Even if the errors were helpful, we still need a way to avoid the truncation. This patch adds the environment variable NODE_PIPE_DIR. If set the tests create pipes in this directory instead of the current defaults. In addition the test harness is updated to remove/delete this directory before/after each test is run. modified: test/common.js modified: test/simple/test-net-pipe-connect-errors.js modified: test/testpy/__init__.py modified: test/simple/test-cluster-eaccess.js Reviewed-By: Julien Gilli <julien.gilli@joyent.com> PR-URL: https://github.com/joyent/node/pull/9381	10 years ago
Fedor Indutny	1442c1c6de	addons: build and test examples fix #6910	11 years ago
Timothy J Fontaine	6cc95b06ea	test: refactor to use common testcfg	11 years ago

Author

SHA1

Message

Date

Michael Dawson

5dd5ce75d7

test: Env variable to specify directory for pipes

At the uv layer pipes are connected with uv_pipe_connect.
The current spec for this method indicates that the maximum
length is limited to the size of length of
sizeof(sockaddr_un.sun_path), typically between 92 and
108 bytes. Anything longer than that just gets truncated.

The simple testsuite currently creates pipes in directories
under the directory where node was built.  In our jenkins
jobs this sometimes ends up being a deep enough path that
the path for the pipes is getting truncated.  The result
is that tests using pipes fail with errors that don't
make it obvious what the problem is.

Even if the errors were helpful, we still need a way
to avoid the truncation.

This patch adds the environment variable NODE_PIPE_DIR.
If set the tests create pipes in this directory instead of
the current defaults.  In addition the test harness is
updated to remove/delete this directory before/after
each test is run.

	modified:   test/common.js
	modified:   test/simple/test-net-pipe-connect-errors.js
	modified:   test/testpy/__init__.py
	modified:   test/simple/test-cluster-eaccess.js

Reviewed-By: Julien Gilli <julien.gilli@joyent.com>
PR-URL: https://github.com/joyent/node/pull/9381

10 years ago

Fedor Indutny

1442c1c6de

addons: build and test examples

fix #6910

11 years ago

Timothy J Fontaine

6cc95b06ea

test: refactor to use common testcfg

11 years ago

3 Commits (b48639befde4ced3a2ebeb98abd409b1310202e8)