lukechilds/node - node - Gitea: Git with a cup of tea

17804 Commits

131 Branches

446 Tags

325 MiB

Tree: b5d8d7c6f9

Commit Graph

Author	SHA1	Message	Date
Rajaram Gaunker	06a617aa21	url: update IDNA error conditions This commit contains three separate changes: - Always return a string from ToUnicode no matter if an error occurred. - Disable CheckHyphens boolean flag. This flag will soon be enabled in the URL Standard, but is implemented manually by selectively ignoring certain errors. - Enable CheckBidi boolean flag per URL Standard update. This allows domain names with hyphens at 3 and 4th position, as well as those with leading and trailing hyphens. They are technically invalid, but seen in the wild. Tests are updated and simplified accordingly. PR-URL: https://github.com/nodejs/node/pull/12966 Fixes: https://github.com/nodejs/node/issues/12965 Refs: https://github.com/whatwg/url/pull/309 Reviewed-By: Daijiro Wachi <daijiro.wachi@gmail.com> Reviewed-By: Timothy Gu <timothygu99@gmail.com>	8 years ago
James M Snell	abc1633de6	url: move originFor, domainToAscii and domainToUnicode Move non-standard methods to `url` module instead of exposing as static methods on the `URL` object. PR-URL: https://github.com/nodejs/node/pull/10512 Reviewed-By: Italo A. Casas <me@italoacasas.com> Reviewed-By: Michaël Zasso <targos@protonmail.com>	8 years ago
Daryl Thayil	f8e07d0486	test: add test for url module domainToAscii and domainToUnicode PR-URL: https://github.com/nodejs/node/pull/10031 Reviewed-By: James M Snell <jasnell@gmail.com>	8 years ago

Author

SHA1

Message

Date

Rajaram Gaunker

06a617aa21

url: update IDNA error conditions

This commit contains three separate changes:

- Always return a string from ToUnicode no matter if an error occurred.
- Disable CheckHyphens boolean flag. This flag will soon be enabled in
  the URL Standard, but is implemented manually by selectively ignoring
  certain errors.
- Enable CheckBidi boolean flag per URL Standard update.

This allows domain names with hyphens at 3 and 4th position, as well as
those with leading and trailing hyphens. They are technically invalid,
but seen in the wild.

Tests are updated and simplified accordingly.

PR-URL: https://github.com/nodejs/node/pull/12966
Fixes: https://github.com/nodejs/node/issues/12965
Refs: https://github.com/whatwg/url/pull/309
Reviewed-By: Daijiro Wachi <daijiro.wachi@gmail.com>
Reviewed-By: Timothy Gu <timothygu99@gmail.com>

8 years ago

James M Snell

abc1633de6

url: move originFor, domainToAscii and domainToUnicode

Move non-standard methods to `url` module instead of exposing as
static methods on the `URL` object.

PR-URL: https://github.com/nodejs/node/pull/10512
Reviewed-By: Italo A. Casas <me@italoacasas.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>

8 years ago

Daryl Thayil

f8e07d0486

test: add test for url module domainToAscii and domainToUnicode

PR-URL: https://github.com/nodejs/node/pull/10031
Reviewed-By: James M Snell <jasnell@gmail.com>

8 years ago

3 Commits (b5d8d7c6f966d5c7d24904b78f20b325b2f13cac)