lukechilds/node - node - Gitea: Git with a cup of tea

13027 Commits

131 Branches

446 Tags

325 MiB

Tree: b690916e5a

Commit Graph

Author	SHA1	Message	Date
Fedor Indutny	d9bf6e0b79	net: use `_server` for internal book-keeping The role of `this.server` is now split between `this._server` and `this.server`. Where the first one is used for counting active connections of `net.Server`, and the latter one is just a public API for users' consumption. The reasoning for this is simple, `TLSSocket` instances wrap `net.Socket` instances, thus both refer to the `net.Server` through the `this.server` property. However, only one of them should be used for `net.Server` connection count book-keeping, otherwise double-decrement will happen on socket destruction. Fix: #5083 PR-URL: https://github.com/nodejs/node/pull/5262 Reviewed-By: James M Snell <jasnell@gmail.com>	9 years ago
Fedor Indutny	f71be242ca	tls: nullify `.ssl` on handle close This is an intermediate fix for an issue of accessing `TLSWrap` fields after the parent handle was destroyed. While `close` listener cleans up this field automatically, it can be done even earlier at the `TLSWrap.close` call. Proper fix is going to be submitted and landed after this one. Fix: #5108 PR-URL: https://github.com/nodejs/node/pull/5168 Reviewed-By: Shigeki Ohtsu <ohtsu@iij.ad.jp>	9 years ago

Author

SHA1

Message

Date

Fedor Indutny

d9bf6e0b79

net: use `_server` for internal book-keeping

The role of `this.server` is now split between `this._server` and
`this.server`. Where the first one is used for counting active
connections of `net.Server`, and the latter one is just a public API for
users' consumption.

The reasoning for this is simple, `TLSSocket` instances wrap
`net.Socket` instances, thus both refer to the `net.Server` through the
`this.server` property. However, only one of them should be used for
`net.Server` connection count book-keeping, otherwise double-decrement
will happen on socket destruction.

Fix: #5083
PR-URL: https://github.com/nodejs/node/pull/5262
Reviewed-By: James M Snell <jasnell@gmail.com>

9 years ago

Fedor Indutny

f71be242ca

tls: nullify `.ssl` on handle close

This is an intermediate fix for an issue of accessing `TLSWrap` fields
after the parent handle was destroyed. While `close` listener cleans up
this field automatically, it can be done even earlier at the
`TLSWrap.close` call.

Proper fix is going to be submitted and landed after this one.

Fix: #5108
PR-URL: https://github.com/nodejs/node/pull/5168
Reviewed-By: Shigeki Ohtsu <ohtsu@iij.ad.jp>

9 years ago

1 Commits (b690916e5a4e0aafb6ea9ff5ce5a7139a39c35ab)