lukechilds/node - node - Gitea: Git with a cup of tea

13305 Commits

131 Branches

446 Tags

325 MiB

Tree: b6fc15347d

Commit Graph

Author	SHA1	Message	Date
Rich Trott	ddac368533	benchmark: fix lint errors PR-URL: https://github.com/nodejs/node/pull/5773 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Myles Borins <myles.borins@gmail.com>	9 years ago
Anton Khlynovskiy	b690916e5a	lib: freelist: use .pop() for allocation Array#pop() is known to be faster than Array#shift(). To be exact, it's O(1) vs. O(n). In this case there's no difference from which side of the "pool" array the object is retrieved, so .pop() should be preferred. PR-URL: https://github.com/nodejs/node/pull/2174 Reviewed-By: mscdex - Brian White <mscdex@mscdex.net> Reviewed-By: jasnell - James M Snell <jasnell@gmail.com> Reviewed-By: ofrobots - Ali Ijaz Sheikh <ofrobots@google.com>	9 years ago

Author

SHA1

Message

Date

Rich Trott

ddac368533

benchmark: fix lint errors

PR-URL: https://github.com/nodejs/node/pull/5773
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Myles Borins <myles.borins@gmail.com>

9 years ago

Anton Khlynovskiy

b690916e5a

lib: freelist: use .pop() for allocation

Array#pop() is known to be faster than Array#shift().
To be exact, it's O(1) vs. O(n). In this case there's no difference
from which side of the "pool" array the object is retrieved,
so .pop() should be preferred.

PR-URL: https://github.com/nodejs/node/pull/2174
Reviewed-By: mscdex - Brian White <mscdex@mscdex.net>
Reviewed-By: jasnell - James M Snell <jasnell@gmail.com>
Reviewed-By: ofrobots - Ali Ijaz Sheikh <ofrobots@google.com>

9 years ago

2 Commits (b6fc15347db2ae0ab4f337596a02484c9e5c3bf2)