lukechilds/node - node - Gitea: Git with a cup of tea

15547 Commits

131 Branches

446 Tags

325 MiB

Tree: b868ce6763

Commit Graph

Author SHA1 Message Date

Author	SHA1	Message	Date
Myles Borins	878bcd43f8	querystring: check that maxKeys is finite There was a very subtle change in behavior introduced with `27def4f` In the past if querystring.parse was given Infinity for maxKeys, everything worked as expected. Check to see is maxKeys is Infinity before forwarding the value to String.prototype.split which causes this regression PR-URL: https://github.com/nodejs/node/pull/5066 Reviewed-By: Evan Lucas <evanlucas@me.com> Reviewed By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com> Reviewed-By: Rod Vagg <rod@vagg.org> Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>	9 years ago

Myles Borins

878bcd43f8

querystring: check that maxKeys is finite

There was a very subtle change in behavior introduced with 27def4f

In the past if querystring.parse was given Infinity for maxKeys,
everything worked as expected.

Check to see is maxKeys is Infinity before forwarding the value to
String.prototype.split which causes this regression

PR-URL: https://github.com/nodejs/node/pull/5066
Reviewed-By: Evan Lucas <evanlucas@me.com>
Reviewed By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
Reviewed-By: Rod Vagg <rod@vagg.org>
Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>

9 years ago

1 Commits (b868ce676361bc58fbc23127943d4974663ab17e)