lukechilds/node - node - Gitea: Git with a cup of tea

Commit Graph

Author	SHA1	Message	Date
Eugene Ostroukhov	2f3865d5f5	inspector: check if connected before waiting Fixes: https://github.com/nodejs/node/issues/10093 PR-URL: https://github.com/nodejs/node/pull/10094 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>	8 years ago
Ben Noordhuis	e27f14f0b4	inspector: /json/version returns object, not array Make /json/version return an object instead of an object wrapped in an array. Fixes: https://github.com/nodejs/node/issues/9760 PR-URL: https://github.com/nodejs/node/pull/9762 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Eugene Ostroukhov <eostroukhov@google.com> Reviewed-By: Santiago Gimeno <santiago.gimeno@gmail.com>	8 years ago
Rich Trott	2486273c0e	test: fix flaky test-inspector Using `socket.destroy()` instead of `socket.end()` fixes more-than-intermittent ECONNRESET issues on Windows. PR-URL: https://github.com/nodejs/node/pull/9727 Fixes: https://github.com/nodejs/node/issues/8804 Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com> Reviewed-By: Eugene Ostroukhov <eostroukhov@google.com>	8 years ago
Rich Trott	103858e95f	test: refactor inspector-helper.js There are two instances of `setTimeout()` called without a duration in `inspector-helper.js`. Change to `setImmediate()` for clarity that it isn't a mistake. PR-URL: https://github.com/nodejs/node/pull/9499 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Eugene Ostroukhov <eostroukhov@google.com> Reviewed-By: Prince John Wesley <princejohnwesley@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>	8 years ago
Eugene Ostroukhov	a41b41a540	inspector: do not prompt to use localhost There are multiple reports of Windows7 not being able to resolve localhost on some setups (web search also confirms that). This change will advertise "127.0.0.1" as inspector host name. Fixes: https://github.com/nodejs/node/issues/9382 Fixes: https://github.com/nodejs/node/issues/9188 PR-URL: https://github.com/nodejs/node/pull/9451 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>	8 years ago
Eugene Ostroukhov	8f00455c51	inspector: switch to new inspector APIs This implementation switches to V8 inspector from the V8 repository. The new inspector integration is now using final APIs and exposes a stable wire protocol, removing the need for pointing the users to specific devtools version. PR-URL: https://github.com/nodejs/node/pull/9028 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>	8 years ago
Ben Noordhuis	3d9b379cd0	inspector: fix request path nullptr dereference Fix a nullptr dereference when an invalid path is requested. Regression introduced in commit `69fc85d` ("inspector: generate UUID for debug targets"), caught by Coverity. PR-URL: https://github.com/nodejs/node/pull/9184 Reviewed-By: Ali Ijaz Sheikh <ofrobots@google.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Eugene Ostroukhov <eostroukhov@google.com> Reviewed-By: James M Snell <jasnell@gmail.com>	8 years ago
Eugene Ostroukhov	da184f4f33	inspector: no URLs when the debugger is connected By convention, inspector protocol targets do not advertise connection URLs when the frontend is already connected as multiple inspector protocol connections are not supported. PR-URL: https://github.com/nodejs/node/pull/8919 Reviewed-By: Aleksey Kozyatinskiy <kozyatinskiy@chromium.org> Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>	8 years ago
Eugene Ostroukhov	69fc85dcb3	inspector: generate UUID for debug targets PR-URL: https://github.com/nodejs/node-private/pull/79 Fixes: https://github.com/nodejs/security/issues/81 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>	8 years ago
Rich Trott	33dd4ec645	test: mark test-inspector flaky on windows PR-URL: https://github.com/nodejs/node/pull/8835 Reviewed-By: Eugene Ostroukhov <eostroukhov@google.com> Reviewed-By: Myles Borins <myles.borins@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>	8 years ago
Eugene Ostroukhov	af2ca7ce06	test: use Buffer.alloc Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Сковорода Никита Андреевич <chalkerx@gmail.com> Reviewed-By: Ilkka Myller <ilkka.myller@nodefield.com> Reviewed-By: Brian White <mscdex@mscdex.net> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> PR-URL: https://github.com/nodejs/node/pull/8748	8 years ago
Eugene Ostroukhov	5acbeb0272	inspector: address race conditions Stress tests uncovered 2 race conditions, when IO events happened during V8 entering event loop on pause or during Node.js shutdown. Fixes: nodejs/node#8669 PR-URL: https://github.com/nodejs/node/pull/8672 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Aleksey Kozyatinskiy <kozyatinskiy@chromium.org>	8 years ago
Teddy Katz	b1b1978ec5	tools: add additional ESLint rules PR-URL: https://github.com/nodejs/node/pull/8643 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Сковорода Никита Андреевич <chalkerx@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Roman Reiss <me@silverwind.io> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: James M Snell <jasnell@keybase.io>	8 years ago
Eugene Ostroukhov	efe4d19240	inspector: report default context Fixes: https://github.com/nodejs/node/issues/8426 PR-URL: https://github.com/nodejs/node/pull/8502 Reviewed-By: bnoordhuis - Ben Noordhuis <info@bnoordhuis.nl>	8 years ago
Eugene Ostroukhov	b4a249f66b	inspector: introduce a smoke test This test executes a simple debug session over the inspector protocol. PR-URL: https://github.com/nodejs/node/pull/8429 Reviewed-By: ofrobots - Ali Ijaz Sheikh <ofrobots@google.com>	8 years ago

15 Commits (c00f64796318f1b714e856db96a1b64b2956a890)