Tree: c084287a60

Commit Graph

2 Commits (c084287a608efcd339d085ae1c48457b31e9920a)

Author	SHA1	Message	Date
Ben Noordhuis	3c85f4e237	test: don't use internal headers in add-on tests There is no real need and it causes endless grief on Windows with some of the upcoming changes. PR-URL: https://github.com/nodejs/node/pull/6734 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>	9 years ago
Fedor Indutny	827ee498e3	buffer: neuter external `nullptr` buffers Neuter external `nullptr` buffers, otherwise their contents will be materialized on access, and the buffer instance will be internalized. This leads to a crash like this: v8::ArrayBuffer::Neuter Only externalized ArrayBuffers can be neutered Fix: #3619 PR-URL: https://github.com/nodejs/node/pull/3624 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Trevor Norris <trev.norris@gmail.com>	9 years ago