lukechilds/node - node - Gitea: Git with a cup of tea

17513 Commits

131 Branches

446 Tags

325 MiB

Tree: c3067b5640

Commit Graph

Author	SHA1	Message	Date
Brian White	6b2cef65c9	http: append Cookie header values with semicolon Previously, separate incoming Cookie headers would be concatenated with a comma, which can cause confusion in userland code when it comes to parsing the final Cookie header value. This commit concatenates using a semicolon instead. Fixes: https://github.com/nodejs/node/issues/11256 PR-URL: https://github.com/nodejs/node/pull/11259 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Roman Reiss <me@silverwind.io> Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>	8 years ago
abouthiroppy	dd629ba973	test: add http_incoming's matchKnownFields test https://github.com/nodejs/node/blob/master/lib/_http_incoming.js#L136 Coverage: https://coverage.nodejs.org/coverage-57f6a106fbc69a47/root/_http_incoming.js.html PR-URL: https://github.com/nodejs/node/pull/10811 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Santiago Gimeno <santiago.gimeno@gmail.com> Reviewed-By: Italo A. Casas <me@italoacasas.com>	8 years ago

Author

SHA1

Message

Date

Brian White

6b2cef65c9

http: append Cookie header values with semicolon

Previously, separate incoming Cookie headers would be concatenated
with a comma, which can cause confusion in userland code when it
comes to parsing the final Cookie header value. This commit
concatenates using a semicolon instead.

Fixes: https://github.com/nodejs/node/issues/11256
PR-URL: https://github.com/nodejs/node/pull/11259
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Roman Reiss <me@silverwind.io>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>

8 years ago

abouthiroppy

dd629ba973

test: add http_incoming's matchKnownFields test

https://github.com/nodejs/node/blob/master/lib/_http_incoming.js#L136
Coverage: https://coverage.nodejs.org/coverage-57f6a106fbc69a47/root/_http_incoming.js.html

PR-URL: https://github.com/nodejs/node/pull/10811
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Santiago Gimeno <santiago.gimeno@gmail.com>
Reviewed-By: Italo A. Casas <me@italoacasas.com>

8 years ago

2 Commits (c3067b56403f73ed4a285b7b21d4a30db65cf479)