lukechilds/node - node - Gitea: Git with a cup of tea

13058 Commits

131 Branches

446 Tags

325 MiB

Tree: c397ba8fa3

Commit Graph

Author	SHA1	Message	Date
Rich Trott	cd79ec268d	test: remove unnecessary assignments common.js needs to be loaded in all tests so that there is checking for variable leaks and possibly other things. However, it does not need to be assigned to a variable if nothing in common.js is referred to elsewhere in the test. PR-URL: https://github.com/nodejs/node/pull/4408 Reviewed-By: James M Snell <jasnell@gmail.com>	9 years ago
Trevor Norris	5d34c81a5c	async_wrap: allow some hooks to be optional Only enforce that the init callback is passed to setupHooks(). The remaining hooks can be optionally passed. Throw if async_wrap.enable() runs before setting the init callback or if setupHooks() is called while async wrap is enabled. Add test to verify calls throw appropriately. PR-URL: https://github.com/nodejs/node/pull/3461 Reviewed-By: Fedor Indutny <fedor@indutny.com>	10 years ago

Author

SHA1

Message

Date

Rich Trott

cd79ec268d

test: remove unnecessary assignments

common.js needs to be loaded in all tests so that there is checking
for variable leaks and possibly other things. However, it does not
need to be assigned to a variable if nothing in common.js is referred
to elsewhere in the test.

PR-URL: https://github.com/nodejs/node/pull/4408
Reviewed-By: James M Snell <jasnell@gmail.com>

9 years ago

Trevor Norris

5d34c81a5c

async_wrap: allow some hooks to be optional

Only enforce that the init callback is passed to setupHooks(). The
remaining hooks can be optionally passed.

Throw if async_wrap.enable() runs before setting the init callback or if
setupHooks() is called while async wrap is enabled.

Add test to verify calls throw appropriately.

PR-URL: https://github.com/nodejs/node/pull/3461
Reviewed-By: Fedor Indutny <fedor@indutny.com>

10 years ago

2 Commits (c397ba8fa35e023f8cdc602ecfb667f1cba22be7)