lukechilds/node - node - Gitea: Git with a cup of tea

15120 Commits

131 Branches

446 Tags

325 MiB

Tree: c457b928d0

Commit Graph

Author	SHA1	Message	Date
Bartosz Sosnowski	d5bc52aa2e	benchmark: use 'yes' instead of echo in a loop This changes child-process-exec-stdout benchmark to use 'yes' instead of echo in a while loop. This makes this benchmark consistent with child-process-read which already uses `yes` and allows this benchmark to be executed on Windows. Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> PR-URL: https://github.com/nodejs/node/pull/8721	9 years ago
Bartosz Sosnowski	5386b23f64	benchmark: fix child-process-exec-stdout on win This benchmark fails on Windows when trying to execute command which is more than 32k in size. This commits skips this one case when running under Windows. PR-URL: https://github.com/nodejs/node/pull/7178 Reviewed-By: Trott - Rich Trott <rtrott@gmail.com> Reviewed-By: orangemocha - Alexis Campailla <orangemocha@nodejs.org>	9 years ago
Rich Trott	c9a5990a76	child_process: measure buffer length in bytes This change fixes a known issue where `maxBuffer` limits by characters rather than bytes. Benchmark added to confirm no performance regression occurs with this change. PR-URL: https://github.com/nodejs/node/pull/6764 Fixes: https://github.com/nodejs/node/issues/1901 Reviewed-By: Brian White <mscdex@mscdex.net>	9 years ago

Author

SHA1

Message

Date

Bartosz Sosnowski

d5bc52aa2e

benchmark: use 'yes' instead of echo in a loop

This changes child-process-exec-stdout benchmark to use 'yes' instead
of echo in a while loop. This makes this benchmark consistent with
child-process-read which already uses `yes` and allows this benchmark
to be executed on Windows.

Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
PR-URL: https://github.com/nodejs/node/pull/8721

9 years ago

Bartosz Sosnowski

5386b23f64

benchmark: fix child-process-exec-stdout on win

This benchmark fails on Windows when trying to execute command which
is more than 32k in size. This commits skips this one case when running
under Windows.

PR-URL: https://github.com/nodejs/node/pull/7178
Reviewed-By: Trott - Rich Trott <rtrott@gmail.com>
Reviewed-By: orangemocha - Alexis Campailla <orangemocha@nodejs.org>

9 years ago

Rich Trott

c9a5990a76

child_process: measure buffer length in bytes

This change fixes a known issue where `maxBuffer` limits by characters
rather than bytes. Benchmark added to confirm no performance regression
occurs with this change.

PR-URL: https://github.com/nodejs/node/pull/6764
Fixes: https://github.com/nodejs/node/issues/1901
Reviewed-By: Brian White <mscdex@mscdex.net>

9 years ago

3 Commits (c457b928d08b4714334de93ff7c3a9857c8c26f4)