lukechilds/node - node - Gitea: Git with a cup of tea

13978 Commits

131 Branches

446 Tags

325 MiB

Tree: c48c318806

Commit Graph

Author SHA1 Message Date

Author	SHA1	Message	Date
Santiago Gimeno	afee32fed5	test: fix `fs-watch-recursive` flakiness on OS X The test is sometimes timing out because of a race condition between the fs event generated on file creation and the event being registered in the kqueue. To avoid this problem, create the file after 100 ms, that is the value used in the `fs_event_watch_dir_recursive` libuv test. PR-URL: https://github.com/nodejs/node/pull/4629 Reviewed-By: Rich Trott <rtrott@gmail.com>	9 years ago
Jeremiah Senkpiel	4067cde7ee	test: abstract skip functionality to common The tap skipping output is so prevalent yet obscure in nature that we ought to move it into it's own function in test/common.js Re-do of `52bae222a3` for v4.x Ref: https://github.com/nodejs/node/pull/6697 PR-URL: https://github.com/nodejs/node/pull/7114 Reviewed-By: Myles Borins <myles.borins@gmail.com>	9 years ago
Sakthipriyan Vairamani	3c158af66e	test: enhance fs-watch-recursive test This patch - issues a TAP plugin parsable message on non darwin/windows boxes - uses `const` wherever applicable - moves the test to parallel PR-URL: https://github.com/nodejs/node/pull/2599 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Johan Bergström <bugs@bergstroem.nu> Reviewed-By: James M Snell <jasnell@gmail.com>	10 years ago

Santiago Gimeno

afee32fed5

test: fix `fs-watch-recursive` flakiness on OS X

The test is sometimes timing out because of a race condition between
the fs event generated on file creation and the event being registered
in the kqueue. To avoid this problem, create the file after 100 ms,
that is the value used in the `fs_event_watch_dir_recursive` libuv test.

PR-URL: https://github.com/nodejs/node/pull/4629
Reviewed-By: Rich Trott <rtrott@gmail.com>

9 years ago

Jeremiah Senkpiel

4067cde7ee

test: abstract skip functionality to common

The tap skipping output is so prevalent yet obscure in nature that we
ought to move it into it's own function in test/common.js

Re-do of 52bae222a3 for v4.x

Ref: https://github.com/nodejs/node/pull/6697
PR-URL: https://github.com/nodejs/node/pull/7114
Reviewed-By: Myles Borins <myles.borins@gmail.com>

9 years ago

Sakthipriyan Vairamani

3c158af66e

test: enhance fs-watch-recursive test

This patch

  - issues a TAP plugin parsable message on non darwin/windows boxes
  - uses `const` wherever applicable
  - moves the test to parallel

PR-URL: https://github.com/nodejs/node/pull/2599
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Johan Bergström <bugs@bergstroem.nu>
Reviewed-By: James M Snell <jasnell@gmail.com>

10 years ago

3 Commits (c48c318806e5e5ee849ff5a0a02dbf9431a02888)