Gene Wu
c80d9d6a93
test: improve asset msg in test
Add result to part of assert message.
PR-URL: https://github.com/nodejs/node/pull/15918
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
8 years ago
Justin Lee
721f6df705
test: remove message from asserts
PR-URL: https://github.com/nodejs/node/pull/15920
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
8 years ago
Pavel Pomerantsev
0fbe0a02df
test: improve an error message
PR-URL: https://github.com/nodejs/node/pull/15921
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
8 years ago
Uttam Pawar
b8b248a9b3
test: added string_decoder.js a parallel test
PR-URL: https://github.com/nodejs/node/pull/15923
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
8 years ago
Joe Grace
c4178abc64
test: use fixtures module instead of common
PR-URL: https://github.com/nodejs/node/pull/15925
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
8 years ago
Charlie Duong
56c0e7d10f
test: replace fixtureDir with fixtures module
This commit replaces the usage of common.fixturesDir with
fixtures.path.
PR-URL: https://github.com/nodejs/node/pull/15823
Reviewed-By: Ryan Graham <r.m.graham@gmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
8 years ago
Alex McKenzie
0e1a9fafdd
test: replaced fixturesDir with fixtures module
This was an assigned task at Node.js Interactive North America 2017.
This replaced the fixturesDir exported by the common module with
the fixturesDir on the common/fixtures module.
PR-URL: https://github.com/nodejs/node/pull/15881
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
8 years ago
Christopher Choi
b5e8ae4ff8
test: use common.fixtures module
Replace common.fixturesDir with usage of the common.fixtures module.
PR-URL: https://github.com/nodejs/node/pull/15891
Reviewed-By: Sam Roberts <vieuxtech@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
8 years ago
Paul Milham
7a8d51c079
test: replaced literals in errors with templates
PR-URL: https://github.com/nodejs/node/pull/15911
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
8 years ago
Russell Dempsey
beb23570dc
test: display better error message for assertion
This commit makes understanding assertion failures easier by
displaying the values that failed the assertion.
PR-URL: https://github.com/nodejs/node/pull/15883
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
8 years ago
heeeunkimmm
3f95a8a69e
test: changed buffer-zero output
Added interpolated strings to display the error value
PR-URL: https://github.com/nodejs/node/pull/15926
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
8 years ago
Alex McKenzie
8baa325185
test: replaced fixturesDir with fixtures module
PR-URL: https://github.com/nodejs/node/pull/15927
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
8 years ago
Faisal Yaqoob
ba6049f7f9
test: remove literal error messages
Assertions will now print the values that caused the assertions
to fail.
PR-URL: https://github.com/nodejs/node/pull/15928
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
8 years ago
Daniel Kostro
96221c2471
test: refactor test to use the fixtures module
PR-URL: https://github.com/nodejs/node/pull/15934
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Timothy Gu <timothygu99@gmail.com>
8 years ago
Greg Matthews
2bf182dc46
test: replace fixturesDir with fixtures module
PR-URL: https://github.com/nodejs/node/pull/15932
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
8 years ago
Alice Tsui
f96745a4d3
test: modify test messages to template literals
PR-URL: https://github.com/nodejs/node/pull/15931
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
8 years ago
BradLarson
3f5f847ed1
test: replace common.fixturesDir with fixture
PR-URL: https://github.com/nodejs/node/pull/15940
Reviewed-By: Sam Roberts <vieuxtech@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
8 years ago
joanne-jjb
31ab2ebbde
test: changes to use template literal
PR-URL: https://github.com/nodejs/node/pull/15937
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
8 years ago
Mujtaba Al-Tameemi
3a265556ec
test: replace fixturesDir with fixtures
PR-URL: https://github.com/nodejs/node/pull/15949
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
8 years ago
Luis Del Águila
fcb0079c5f
test: remove common.fixturesDir
Replace `common.fixturesDir` with usage of the `common.fixtures` module
PR-URL: https://github.com/nodejs/node/pull/15950
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
8 years ago
dpaulino
582749e338
test: removed string from assert message arg
PR-URL: https://github.com/nodejs/node/pull/15954
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
8 years ago
Brant Barger
b08ae3a8e4
test: replace literal with template string
PR-URL: https://github.com/nodejs/node/pull/15957
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
8 years ago
jacjam
ca4e549410
test: upgrade from fixturesDir to fixtures.path
The common/fixtures module provides convenience methods
for working with files in the test/fixtures directory.
PR-URL: https://github.com/nodejs/node/pull/15960
Reviewed-By: Daijiro Wachi <daijiro.wachi@gmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
8 years ago
Chris Budy
ab3c84fc25
test: use defaultHistoryPath instead of path.join
PR-URL: https://github.com/nodejs/node/pull/15969
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
8 years ago
BinarySo1o
37681b5e09
test: replace fixturesDir with fixtures module
PR-URL: https://github.com/nodejs/node/pull/15961
Reviewed-By: Daijiro Wachi <daijiro.wachi@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
8 years ago
jopann
0dbff4c862
test: replaced fixturesDir with common.fixtures
PR-URL: https://github.com/nodejs/node/pull/15971
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
8 years ago
Barry Tam
96eba098ef
test: replacing assert message with template
PR-URL: https://github.com/nodejs/node/pull/15974
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
8 years ago
Laura Cabrera
0d38e6d01f
test: use common.fixtures module in test-preload
PR-URL: https://github.com/nodejs/node/pull/15975
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
8 years ago
Alec Ferguson
91724cb2a1
test: more informative test failure messages
PR-URL: https://github.com/nodejs/node/pull/15977
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
8 years ago
Luke Greenleaf
99237cf00d
test: alter assert.strictEqual to default message
PR-URL: https://github.com/nodejs/node/pull/15978
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
8 years ago
Sean Cox
b050c14d91
test: replaced common.fixturesDir with readKey
PR-URL: https://github.com/nodejs/node/pull/15933
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
8 years ago
Annie Weng
4457f4feb9
test: replace fixturesDir in tls-env-bad-extra-ca
PR-URL: https://github.com/nodejs/node/pull/15813
Reviewed-By: Ryan Graham <r.m.graham@gmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
8 years ago
Emily Marigold Klassen
41b65b9fa3
test: use common.fixtures in checkServerIdentity
PR-URL: https://github.com/nodejs/node/pull/15951
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
8 years ago
rhalldearn
b3a8bf3dca
test: replaced common.fixturesDir with readKey
PR-URL: https://github.com/nodejs/node/pull/15952
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
8 years ago
John Miller
b13e660a47
test: use fixtures.path for cmd string building
PR-URL: https://github.com/nodejs/node/pull/15982
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
8 years ago
Thomas Schorn
59e6791fe5
test: replace fixturesDir with fixtures.readKey
PR-URL: https://github.com/nodejs/node/pull/15948
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
8 years ago
ashleyraymaceli
86d803b385
test: replace common.fixturesDir with readKey
PR-URL: https://github.com/nodejs/node/pull/15946
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
8 years ago
Sam Skjonsberg
eb08e3e5fb
test: replace common.fixturesDir with fixtures.
Replaces the use of `common.fixturesDir` with the generic `fixtures`
mechanism.
PR-URL: https://github.com/nodejs/node/pull/15802
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
8 years ago
gbugaisky
5ca1c7a9c5
test: update test to use fixtures module
Updated the test-http2-create-client-connect tests to
use the test fixures module instead of the common
module.
PR-URL: https://github.com/nodejs/node/pull/15955
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
8 years ago
rachelnicole
bdf711dc62
test: replace fixturesDir with common.fixtures
PR-URL: https://github.com/nodejs/node/pull/16051
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
8 years ago
Saeed H
5843b2c945
test: remove messages in assert.strictEqual
PR-URL: https://github.com/nodejs/node/pull/16014
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
8 years ago
Ruxandra Fediuc
09d8b3576f
test: improve coverage for 'internal/errors'
PR-URL: https://github.com/nodejs/node/pull/16055
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Evan Lucas <evanlucas@me.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Yuta Hiroto <hello@about-hiroppy.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
8 years ago
bitandbang
d56f03caeb
test: update fixturesDir to fixtures.readKey
PR-URL: https://github.com/nodejs/node/pull/16016
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Refael Ackermann <refack@gmail.com>
8 years ago
Paul Berry
6e1948ea06
test: replace fixturesDir with common.fixtures
PR-URL: https://github.com/nodejs/node/pull/15973
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
8 years ago
Pooya Paridel
d2c0978831
test: replace fixturesDir with common.fixtures
PR-URL: https://github.com/nodejs/node/pull/15837
Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
8 years ago
James M. Greene
1c97fa76f3
test: update 'fixturesDir' refs in a test file
This was a task from Code & Learn at NINA17.
PR-URL: https://github.com/nodejs/node/pull/15824
Reviewed-By: Ryan Graham <r.m.graham@gmail.com>
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
8 years ago
Jonathan Eskew
ee587f39ae
test: add tests of querystring benchmark
PR-URL: https://github.com/nodejs/node/pull/16052
Reviewed-By: Evan Lucas <evanlucas@me.com>
Reviewed-By: Timothy Gu <timothygu99@gmail.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
8 years ago
Greg Byram
d36433e1b6
test: use fixtures.readKey in https-agent test
PR-URL: https://github.com/nodejs/node/pull/15913
Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
8 years ago
Bruce Fletcher
baa156f39d
test: add common.fixtures to https-req-split
Replaced readFileSync with fixtures.readKey.
PR-URL: https://github.com/nodejs/node/pull/15801
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Daijiro Wachi <daijiro.wachi@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
8 years ago
Trivikram Kamat
fabd618eef
test: http2 stored settings returned when present
Refs: #14985
PR-URL: https://github.com/nodejs/node/pull/15751
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
8 years ago