lukechilds/node - node - Gitea: Git with a cup of tea

14405 Commits

131 Branches

446 Tags

325 MiB

Tree: caf1ba15f9

Commit Graph

Author	SHA1	Message	Date
Rich Trott	b2b2bc2293	test: move timer-dependent test to sequential `test-regress-GH-897` is dependent on a timer firing within a period of time. Especially on some of the FreeBSD hosts on CI, we have seen tests like that fail when run in parallel. (This may have nothing to do with FreeBSD and may just mean that the hosts are resource-constrained.) Move this test to sequential as we have done with several other timer-dependent tests recently. The test has also been refactored and documented via comments. PR-URL: https://github.com/nodejs/node/pull/9487 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Santiago Gimeno <santiago.gimeno@gmail.com> Reviewed-By: Minwoo Jung <jmwsoft@gmail.com>	8 years ago

Author

SHA1

Message

Date

Rich Trott

b2b2bc2293

test: move timer-dependent test to sequential

`test-regress-GH-897` is dependent on a timer firing within a period of
time. Especially on some of the FreeBSD hosts on CI, we have seen tests
like that fail when run in parallel. (This may have nothing to do with
FreeBSD and may just mean that the hosts are resource-constrained.) Move
this test to sequential as we have done with several other
timer-dependent tests recently.

The test has also been refactored and documented via comments.

PR-URL: https://github.com/nodejs/node/pull/9487
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Santiago Gimeno <santiago.gimeno@gmail.com>
Reviewed-By: Minwoo Jung <jmwsoft@gmail.com>

8 years ago

1 Commits (caf1ba15f99848401ec4893ee400db6891023ab7)