lukechilds/node - node - Gitea: Git with a cup of tea

15834 Commits

131 Branches

446 Tags

325 MiB

Tree: cb507af454

Commit Graph

Author	SHA1	Message	Date
Daniel Bevenius	690bdede13	test: fix lint error regarding unused commons const Currently, make lint is failing with the following error: 3:7 error 'common' is assigned a value but never used no-unused-vars ✖ 1 problem (1 error, 0 warnings) PR-URL: https://github.com/nodejs/node/pull/9334 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>	8 years ago
Italo A. Casas	fd16eed8ea	test: writable stream ending state Add a test for _writableState.ending, when ending becomes true, but the stream is not finished/ended yet. PR-URL: https://github.com/nodejs/node/pull/8707 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Related: https://github.com/nodejs/node/issues/8686	8 years ago

Author

SHA1

Message

Date

Daniel Bevenius

690bdede13

test: fix lint error regarding unused commons const

Currently, make lint is failing with the following error:
3:7  error  'common' is assigned a value but never used  no-unused-vars
✖ 1 problem (1 error, 0 warnings)

PR-URL: https://github.com/nodejs/node/pull/9334
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>

8 years ago

Italo A. Casas

fd16eed8ea

test: writable stream ending state

Add a test for _writableState.ending, when ending becomes true,
but the stream is not finished/ended yet.

PR-URL: https://github.com/nodejs/node/pull/8707
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Related: https://github.com/nodejs/node/issues/8686

8 years ago

2 Commits (cb507af454196b9f28169ebd69cac9bf907cf274)