lukechilds/node - node - Gitea: Git with a cup of tea

14184 Commits

131 Branches

446 Tags

325 MiB

Tree: d1b6407395

Commit Graph

Author	SHA1	Message	Date
Jeremiah Senkpiel	759e8fdd18	timers: bail from intervals if _repeat is bad PR-URL: https://github.com/nodejs/node/pull/10365 Ref: https://github.com/nodejs/node/pull/9685 Reviewed-By: Myles Borins <myles.borins@gmail.com>	8 years ago
Jeremiah Senkpiel	553d95da15	timers: use consistent checks for canceled timers Previously not all codepaths set `timer._idleTimeout = -1` for canceled or closed timers, and not all codepaths checked it either. Unenroll uses this to say that a timer is indeed closed and it is the closest thing there is to an authoritative source for this. Refs: https://github.com/nodejs/node/pull/9606 Fixes: https://github.com/nodejs/node/issues/9561 PR-URL: https://github.com/nodejs/node/pull/9685 Reviewed-By: Rich Trott <rtrott@gmail.com> Conflicts: lib/timers.js	8 years ago

Author

SHA1

Message

Date

Jeremiah Senkpiel

759e8fdd18

timers: bail from intervals if _repeat is bad

PR-URL: https://github.com/nodejs/node/pull/10365
Ref: https://github.com/nodejs/node/pull/9685

Reviewed-By: Myles Borins <myles.borins@gmail.com>

8 years ago

Jeremiah Senkpiel

553d95da15

timers: use consistent checks for canceled timers

Previously not all codepaths set `timer._idleTimeout = -1` for canceled
or closed timers, and not all codepaths checked it either.

Unenroll uses this to say that a timer is indeed closed and it is the
closest thing there is to an authoritative source for this.

Refs: https://github.com/nodejs/node/pull/9606
Fixes: https://github.com/nodejs/node/issues/9561
PR-URL: https://github.com/nodejs/node/pull/9685
Reviewed-By: Rich Trott <rtrott@gmail.com>

 Conflicts:
	lib/timers.js

8 years ago

2 Commits (d1b6407395d23a6eeff981155ead792ddbd0859c)