lukechilds/node - node - Gitea: Git with a cup of tea

12605 Commits

131 Branches

446 Tags

325 MiB

Tree: d47f6ba768

Commit Graph

Author SHA1 Message Date

Author	SHA1	Message	Date
cjihrig	5ba08fbf76	src: fix line numbers on core errors In `dfee4e3712`, the module wrapper and line offset used when wrapping module code was changed to better report errors on the first line of modules. However, that commit did not update the runInThisContext() call used to execute the core modules, so their error line numbers have been off by one. This commit provides the correct lineOffset for core modules. Refs: https://github.com/nodejs/node/pull/2867 PR-URL: https://github.com/nodejs/node/pull/4254 Reviewed-By: Brian White <mscdex@mscdex.net> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Minwoo Jung <jmwsoft@gmail.com> Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>	9 years ago

cjihrig

5ba08fbf76

src: fix line numbers on core errors

In dfee4e3712, the module wrapper
and line offset used when wrapping module code was changed to
better report errors on the first line of modules. However, that
commit did not update the runInThisContext() call used to
execute the core modules, so their error line numbers have been
off by one. This commit provides the correct lineOffset for core
modules.

Refs: https://github.com/nodejs/node/pull/2867
PR-URL: https://github.com/nodejs/node/pull/4254
Reviewed-By: Brian White <mscdex@mscdex.net>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Minwoo Jung <jmwsoft@gmail.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>

9 years ago

1 Commits (d47f6ba7681103ad03d11fa98a984574e990f4e3)