lukechilds/node - node - Gitea: Git with a cup of tea

Commit Graph

Author	SHA1	Message	Date
isaacs	199fa9f8dd	crypto: Don't ignore verify encoding argument	12 years ago
isaacs	a241deb19a	crypto: Pass encodings for Hmac digest	12 years ago
isaacs	c1e8c8de1c	crypto: Pass encodings to C++ for Sign/Verify	12 years ago
isaacs	430dc39e87	crypto: use StringBytes::Encode	12 years ago
isaacs	a1eacdf12a	crypto: Pass strings to binding layer directly	12 years ago
mscdex	c4379a5554	src: fix potential memory leak on early return	12 years ago
mscdex	2322580dfb	src: don't initialize variable before assignment	12 years ago
Trevor Norris	659fb238e7	crypto: fix return Local Handle w/o scope.Close() A new String was being created and returned, but was not sent through the scope.Close(), which caused it to be cleaned up before being returned.	12 years ago
Ben Noordhuis	0d5595ac60	Revert "crypto: use better memory BIO implementation" This change shouldn't have landed in the stable branch. It's a feature, not a bug fix. This reverts commit `58f93ffc4a`. This reverts commit `8c8ebe49b6`. This reverts commit `ba0f7b8066`. This reverts commit `21f3c5c367`.	12 years ago
Fedor Indutny	037bcac7ba	crypto: dh secret should be left-padded DH_compute_secret() may return key that is smaller than input buffer, in such cases key should be left-padded because it is a BN (big number). fix #5239	12 years ago
Fedor Indutny	77715edee8	crypto: zero is not an error if writing 0 bytes fix #5128	12 years ago
Fedor Indutny	58f93ffc4a	crypto: use better memory BIO implementation	12 years ago
Fedor Indutny	4580be0882	tls: handle SSL_ERROR_ZERO_RETURN see #5004	12 years ago
Ben Noordhuis	cfd0dca9ae	crypto: make getCiphers() return non-SSL ciphers Commit `f53441a` added crypto.getCiphers() as a function that returns the names of SSL ciphers. Commit `14a6c4e` then added crypto.getHashes(), which returns the names of digest algorithms, but that creates a subtle inconsistency: the return values of crypto.getHashes() are valid arguments to crypto.createHash() but that is not true for crypto.getCiphers() - the returned values are only valid for SSL/TLS functions. Rectify that by adding tls.getCiphers() and making crypto.getCiphers() return proper cipher names.	12 years ago
Marcel Laverdet	1526909083	tls: remove harmful unnecessary bounds checking The EncIn, EncOut, ClearIn & ClearOut functions are victims of some code copy + pasting. A common line copied to all of them is: `if (off >= buffer_length) { ...` `448e0f43` corrected ClearIn's check from `>=` to `>`, but left the others unchanged (with an incorrect bounds check). However, if you look down at the next very next bounds check you'll see: `if (off + len > buffer_length) { ...` So the check is actually obviated by the next line, and should be removed. This fixes an issue where writing a zero-length buffer to an encrypted pair's encrypted stream you would get a crash.	12 years ago
Ben Noordhuis	628bd81afb	crypto: check randomBytes() size argument Throw a TypeError if size > 0x3fffffff. Avoids the following V8 fatal error: FATAL ERROR: v8::Object::SetIndexedPropertiesToExternalArrayData() length exceeds max acceptable value Fixes #5126.	12 years ago
Ben Noordhuis	7189b3ed33	crypto: don't assert when calling Cipher#final() twice Remove the assert() that triggered when Cipher#final() or Decipher#final() was called twice. Fixes #4886.	12 years ago
Ben Noordhuis	c6e2db2f14	crypto: clear error stack Clear OpenSSL's error stack on return from Connection::HandleSSLError(). This stops stale errors from popping up later in the lifecycle of the SSL connection where they would cause spurious failures. This commit causes a 1-2% performance regression on `make bench-tls`. We'll address that in follow-up commits if possible but let's ensure correctness first. Fixes #4771.	12 years ago
Ben Noordhuis	51f6e6a9b3	src, test: downgrade to v8 3.14 api	12 years ago
Victor Costan	e235bce2ba	Fix crypto.hmac behavior with empty keys. node 0.9.6 introduced Buffer changes that cause the key argument of Hmac::HmacInit (used in crypto.createHmac) to be NULL when the key is empty. This argument is passed to OpenSSL's HMAC_Init, which does not like NULL keys. This change works around the issue by passing an empty string to HMAC_Init when the key is empty, and adds crypto.createHmac tests for the edge cases of empty keys and values.	12 years ago
Ben Noordhuis	f5f9e8da71	crypto: improve cipher/decipher error messages Throw the OpenSSL error string instead of the rather less informative error message "fail".	12 years ago
Ben Noordhuis	7788a6bf85	src: pass node_isolate to Undefined()	12 years ago
Ben Noordhuis	c7d7ae1fe2	src: pass node_isolate to Null()	12 years ago
Ben Noordhuis	109f73b2c0	src: pass node_isolate to True() and False()	12 years ago
Ben Noordhuis	01c3d0aa88	src: pass node_isolate to Local<>::New	12 years ago
Ben Noordhuis	6573fc3502	src: pass node_isolate to Integer::New	12 years ago
Ben Noordhuis	6cf68aead6	deps: upgrade libuv to e079a99	12 years ago
Fedor Indutny	51d5655efa	crypto: fix leak in GetPeerCertificate	12 years ago
Fedor Indutny	276245d26f	crypto: fix leak in GetPeerCertificate	12 years ago
Ben Noordhuis	335f20896a	crypto: allow negative numbers in setOptions() OR'ing together two large values, like `SSL_OP_ALL \| SSL_OP_NO_TICKET`, produces a negative number. To wit: assert((0x80000000 \| 0x4000) === -0x7fffc000); // true assert((0x80000000 \| 0x4000) === 0x80004000); // false! It's easy to work around by doing a logical shift, like this: assert((0x80000000 \| 0x4000) >>> 0 === 0x80004000); // true But that's not very intuitive. Let's be more lenient in what we accept.	12 years ago
Sergey Kholodilov	019ad346e0	crypto: fix ssl error handling Make HandleSSLError() correctly process a zero status code: sometimes it indicates an error and sometimes it doesn't.	12 years ago
isaacs	1122e3af28	crypto: Style. Prefer 'char' over 'char '	12 years ago
isaacs	f2fa97f178	crypto: Remove many unnecessary toObjects	12 years ago
isaacs	c87b524c5f	crypto: Clean up buffer handling and DH methods	12 years ago
isaacs	bfb9d5bbe6	crypto: Binding only accepts buffers	12 years ago
Ben Noordhuis	844a0058d0	crypto: fix DH use-after-free and memory leak Fix a use-after-free bug and a memory leak in the error path of DiffieHellman::ComputeSecret(). * the BIGNUM key was used after being freed with BN_free(). * the output buffer was not freed	12 years ago
Ben Noordhuis	de18e29784	crypto: fix DH 1 byte buffer underflow Passing a bad key to DiffieHellman::ComputeSecret() made it zero the byte before the heap allocated buffer due to an erroneous size calculation.	12 years ago
Ben Noordhuis	14a6c4efb8	crypto: add crypto.getHashes()	12 years ago
Ben Noordhuis	f53441ab1f	crypto: add crypto.getCiphers() Returns a list of, unsurprisingly, the available ciphers.	12 years ago
Ben Noordhuis	eec8c2edaf	crypto: fix -Wtautological-compare warning	12 years ago
Fedor Indutny	63ff449d87	crypto: bring module into modern age Introduce 'buffer' encoding, allow returning and giving buffers as arguments of 'crypto' routines. Fix #3278	12 years ago
Ben Noordhuis	bec863b7de	crypto: use uv_thread_self()	12 years ago
Ben Noordhuis	eaf1343100	crypto: remove legacy openssl compatibility code Remove code that works around a padding bug in older versions of openssl, the bundled version of openssl contains the bug fix.	12 years ago
Fedor Indutny	8e0c830cd0	tls: async session storage	13 years ago
Ben Noordhuis	7dfa587d18	crypto, tls: make setSNICallback() compatible with domains	13 years ago
Ben Noordhuis	7d0543c128	crypto: make pbkdf2() compatible with domains	13 years ago
Ben Noordhuis	d1eff9ab68	crypto: make randomBytes() compatible with domains Don't execute the callback in the context of the global object. MakeCallback() tries to apply the active domain to the callback. If the user polluted the global object with a 'domain' property, as in the code example below, MakeCallback() will try to apply that. Example: domain = {}; // missing var keyword is intentional crypto.randomBytes(8, cb); // TypeError: undefined is not a function Fixes #3956.	13 years ago
Ben Noordhuis	870307de75	crypto: fix build error on OS X pthread_t is a pointer type on OS X but an unsigned long on most other platforms. Use a C style cast because reinterpret_cast nor static_cast work in all cases.	13 years ago
Ben Noordhuis	298f6bff5b	crypto: use CRYPTO_THREADID_set_callback() Don't use CRYPTO_set_id_callback(), it's deprecated.	13 years ago
Ben Noordhuis	2a30d328fa	crypto: add sync interface to crypto.pbkdf2() Fixes #3766.	13 years ago

1 2 3 4 5

220 Commits (d5d5170c359fc96f36650cdd9b84cbb013c33735)