lukechilds/node - node - Gitea: Git with a cup of tea

Commit Graph

Author	SHA1	Message	Date
cjihrig	8c0f776f23	test: add known issue test for #7788 `15157c3c3d` changed the CLI REPL to default to useGlobal: false by default. This caused the regression seen in https://github.com/nodejs/node/issues/7788. This commit adds a known issue test while a proper resolution is determined. Refs: https://github.com/nodejs/node/pull/5703 Refs: https://github.com/nodejs/node/issues/7788 PR-URL: https://github.com/nodejs/node/pull/7793 Reviewed-By: Rich Trott <rtrott@gmail.com>	8 years ago
Prince J Wesley	bb9eabec40	repl: Mitigate vm #548 function redefinition issue ```js node 🙈 ₹ git:(upstream ⚡ repl-tmp-548) ./node > function name() { return "node"; }; undefined > name() 'node' > function name() { return "nodejs"; }; undefined > name() 'nodejs' > ``` Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Lance Ball <lball@redhat.com>	8 years ago
Rich Trott	0268fd0a9f	child_process: preserve argument type A previous fix for a `maxBuffer` bug resulted in a change to the argument type for the `data` event on `child.stdin` and `child.stdout` when using `child_process.exec()`. This fixes the `maxBuffer` bug in a way that does not have that side effect. PR-URL: https://github.com/nodejs/node/pull/7391 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Jackson Tian <shyvo1987@gmail.com> Fixes: https://github.com/nodejs/node/issues/7342 Refs: https://github.com/nodejs/node/issues/1901	8 years ago
Rich Trott	8da541bf5f	Revert "child_process: measure buffer length in bytes" This reverts commit `c9a5990a76`. PR-URL: https://github.com/nodejs/node/pull/7391 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Jackson Tian <shyvo1987@gmail.com>	8 years ago
Rich Trott	c96457403e	test: add test for exec() known issue PR-URL: https://github.com/nodejs/node/pull/7375 Refs: https://github.com/nodejs/node/issues/7342 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Santiago Gimeno <santiago.gimeno@gmail.com>	8 years ago
Rich Trott	c9a5990a76	child_process: measure buffer length in bytes This change fixes a known issue where `maxBuffer` limits by characters rather than bytes. Benchmark added to confirm no performance regression occurs with this change. PR-URL: https://github.com/nodejs/node/pull/6764 Fixes: https://github.com/nodejs/node/issues/1901 Reviewed-By: Brian White <mscdex@mscdex.net>	9 years ago
Rich Trott	0912b88320	test: make stdout buffer test more robust test-stdout-buffer-flush-on-exit is unfortunately non-deterministic. It will, every so often, pass when it is supposed to fail. This is currently guarded against by running the test with three different long strings. This change increases it to five to reduce the false negatives. PR-URL: https://github.com/nodejs/node/pull/6633 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Santiago Gimeno <santiago.gimeno@gmail.com>	9 years ago
Rich Trott	5d0b1f4ffa	test: run known_issues tests in CI Add `known_issues` tests to `make test` and `make test-ci` targets and their equivalents on Windows. PR-URL: https://github.com/nodejs/node/pull/6559 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net>	9 years ago
Rich Trott	c4006ddfc3	test: fix unreliable known_issues test `test-stdout-buffer-flush-on-exit` was not failing reliably on POSIX machines and not failing at all on Windows. Revised test fails reliably on POSIX and is skipped (in CI) on Windows where the issue does not exist. Fixes: https://github.com/nodejs/node/issues/6527 PR-URL: https://github.com/nodejs/node/pull/6555 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Joao Reis <reis@janeasystems.com> Reviewed-By: Santiago Gimeno <santiago.gimeno@gmail.com>	9 years ago
James M Snell	fa542ebcfd	test: add failing url parse tests as known_issue url resolve and parse do not currently adhere to the same url spec parsing rules that browsers use, which leads to some issues. This addition to test/known_issues creates a set of tests based on the w3c/whatwg test suite from: Refs: https://github.com/w3c/web-platform-tests/tree/master/url PR-URL: https://github.com/nodejs/node/pull/5885 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Brian White <mscdex@mscdex.net>	9 years ago
Brian White	e38bade828	events: don't inherit from Object.prototype This commit safely allows event names that are named the same as properties that are ordinarily inherited from Object.prototype such as __proto__. Fixes: https://github.com/nodejs/node/issues/728 PR-URL: https://github.com/nodejs/node/pull/6092 Reviewed-By: Evan Lucas <evanlucas@me.com> Reviewed-By: James M Snell <jasnell@gmail.com>	9 years ago
Sakthipriyan Vairamani	854f758169	test: fix offending max-len linter error Refer: https://github.com/nodejs/node/pull/5935 PR-URL: https://github.com/nodejs/node/pull/5980 Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com> Reviewed-By: Phillip Johnsen <johphi@gmail.com>	9 years ago
Jeremiah Senkpiel	d6c9f64e98	test: stdin is not always a net.Socket `<`-ing a file into stdin actually results in a `fs.ReadStream`, rather than a `tty.ReadStream`, and as such does not inherit from net.Socket, unlike the other possible stdin options. Refs: https://github.com/nodejs/node/pull/5916 PR-URL: https://github.com/nodejs/node/pull/5935 Reviewed-By: Colin Ihrig <cjihrig@gmail.com>	9 years ago
Rich Trott	33c27f8fcf	test: add known_issues test for GH-2148 PR-URL: https://github.com/nodejs/node/pull/5920 Refs: https://github.com/nodejs/node/issues/2148 Reviewed-By: Brian White <mscdex@mscdex.net>	9 years ago
cjihrig	10bc673123	test: add batch of known issue tests This commit adds tests for several known issues. Refs: https://github.com/nodejs/node/issues/1901 Refs: https://github.com/nodejs/node/issues/728 Refs: https://github.com/nodejs/node/issues/4778 Refs: https://github.com/nodejs/node/issues/947 Refs: https://github.com/nodejs/node/issues/2734 PR-URL: https://github.com/nodejs/node/pull/5653 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com>	9 years ago
cjihrig	e38e2a6012	test: bug repro for vm function redefinition This commit adds a failing test case for the vm module. Currently, if runInContext() defines a function, and a later call to runInContext() redefines the same function, the original function is not overwritten. Refs: https://github.com/nodejs/node/issues/548 PR-URL: https://github.com/nodejs/node/pull/5528 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Wyatt Preul <wpreul@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com>	9 years ago
cjihrig	32e1f9d0b5	tools: support testing known issues This commit adds a known_issues directory to the test directory for scripts that reproduce known bugs. Since these scripts are expected to fail, it also adds a --expect-fail flag to test.py which reports tests as successful when they fail. Refs: https://github.com/nodejs/testing/issues/18 PR-URL: https://github.com/nodejs/node/pull/5528 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Wyatt Preul <wpreul@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com>	9 years ago

17 Commits (db6253f94a7e499b2bacf5998a246c7cd06f7245)