lukechilds/node - node - Gitea: Git with a cup of tea

19114 Commits

131 Branches

446 Tags

325 MiB

Tree: de2f4ea105

Commit Graph

Author	SHA1	Message	Date
Trivikram Kamat	7f0183e6c3	http2: setting shuttingDown=true after validation In shutdown(), shuttingDown was set to true before validating options. If invalid options are passed, error was thrown and server remained in shuttingDown state. This code change fixes it. PR-URL: https://github.com/nodejs/node/pull/15676 Fixes: https://github.com/nodejs/node/issues/15666 Refs: https://github.com/nodejs/node/issues/14985 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>	8 years ago

Author

SHA1

Message

Date

Trivikram Kamat

7f0183e6c3

http2: setting shuttingDown=true after validation

In shutdown(), shuttingDown was set to true before validating options.
If invalid options are passed, error was thrown and server remained in
shuttingDown state. This code change fixes it.

PR-URL: https://github.com/nodejs/node/pull/15676
Fixes: https://github.com/nodejs/node/issues/15666
Refs: https://github.com/nodejs/node/issues/14985
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>

8 years ago

1 Commits (de2f4ea1052c001a73e4762c4dbaa6f1c3e56ef8)