lukechilds/node - node - Gitea: Git with a cup of tea

Author	SHA1	Message	Date
Domenic Denicola	fd3657610e	vm: update API to use options argument Passing a filename is still supported in place of certain options arguments, for backward-compatibility, but timeout and display-errors are not translated since those were undocumented. Also managed to eliminate an extra stack trace line by not calling through the `createScript` export. Added a few message tests to show how `displayErrors` works.	12 years ago
Domenic Denicola	9c110d8027	vm: add isContext; prevent double-contextifying Previously, calling `vm.createContext(o)` repeatedly on the same `o` would cause new C++ `ContextifyContext`s to be created and stored on `o`, while the previous resident went off into leaked-memory limbo. Now, repeatedly trying to contextify a sandbox will do nothing after the first time. To detect this, an independently-useful `vm.isContext(sandbox)` export was added.	12 years ago
isaacs	eef552774e	vm: Put back display_errors flag This is an important part of the repl use-case. TODO: The arg parsing in vm.runIn*Context() is rather wonky. It would be good to move more of that into the Script class, and/or an options object.	12 years ago
Domenic Denicola	7afdba6e0b	vm, core, module: re-do vm to fix known issues As documented in #3042 and in [1], the existing vm implementation has many problems. All of these are solved by @brianmcd's [contextify][2] package. This commit uses contextify as a conceptual base and its code core to overhaul the vm module and fix its many edge cases and caveats. Functionally, this fixes #3042. In particular: - A context is now indistinguishable from the object it is based on (the "sandbox"). A context is simply a sandbox that has been marked by the vm module, via `vm.createContext`, with special internal information that allows scripts to be run inside of it. - Consequently, items added to the context from anywhere are immediately visible to all code that can access that context, both inside and outside the virtual machine. This commit also smooths over the API very slightly: - Parameter defaults are now uniformly triggered via `undefined`, per ES6 semantics and previous discussion at [3]. - Several undocumented and problematic features have been removed, e.g. the conflation of `vm.Script` with `vm` itself, and the fact that `Script` instances also had all static `vm` methods. The API is now exactly as documented (although arguably the existence of the `vm.Script` export is not yet documented, just the `Script` class itself). In terms of implementation, this replaces node_script.cc with node_contextify.cc, which is derived originally from [4] (see [5]) but has since undergone extensive modifications and iterations to expose the most useful C++ API and use the coding conventions and utilities of Node core. The bindings exposed by `process.binding('contextify')` (node_contextify.cc) replace those formerly exposed by `process.binding('evals')` (node_script.cc). They are: - ContextifyScript(code, [filename]), with methods: - runInThisContext() - runInContext(sandbox, [timeout]) - makeContext(sandbox) From this, the vm.js file builds the entire documented vm module API. node.js and module.js were modified to use this new native binding, or the vm module itself where possible. This introduces an extra line or two into the stack traces of module compilation (and thus into most stack traces), explaining the changed tests. The tests were also updated slightly, with all vm-related simple tests consolidated as test/simple/test-vm-* (some of them were formerly test/simple/test-script-*). At the same time they switched from `common.debug` to `console.error` and were updated to use `assert.throws` instead of rolling their own error-testing methods. New tests were also added, of course, demonstrating the new capabilities and fixes. [1]: http://nodejs.org/docs/v0.10.16/api/vm.html#vm_caveats [2]: https://github.com/brianmcd/contextify [3]: https://github.com/joyent/node/issues/5323#issuecomment-20250726 [4]: `bf123f3ef9/src/contextify.cc` [5]: https://gist.github.com/domenic/6068120	12 years ago
isaacs	22c68fdc1d	src: Replace macros with util functions	12 years ago
Ben Noordhuis	0330bdf519	lib: macro-ify type checks Increases the grep factor. Makes it easier to harmonize type checks across the code base.	12 years ago
isaacs	959a19e118	lint	13 years ago
isaacs	44daa9836b	Wrap NodeScript binding class in JavaScript layer This makes it easy to prevent errors where Script methods are called on non-script objects, resulting in Assertion failures.	13 years ago
Ryan Dahl	26834b0524	Revert "vm context with accessors" This reverts commit `4527de8cba`. Causes segfault in test/message/undefined_reference_in_new_context.js	13 years ago
Fedor Indutny	4527de8cba	vm context with accessors true copy of sandbox properties catch sealed errors, pass global's prototype to CloneObject Fixes #1673	13 years ago
Ryan Dahl	75db1995b6	Don't conflict with V8's Script class Closes GH-203.	14 years ago
Ryan Dahl	55048cdf79	Update copyright headers	14 years ago
Ryan Dahl	dd53ceebe4	lint	14 years ago
Ryan Dahl	8b1082825c	Rename require('javascript') to require('vm')	14 years ago
isaacs	d39d3cec65	Make the javascript module API nodey. Add a createScript function, and put stuff on exports instead of hiding it in exports.Script.	14 years ago
Ryan Dahl	d787a444c5	Use require('javascript') instead of process.binding('evals')	14 years ago