lukechilds/node - node - Gitea: Git with a cup of tea

15212 Commits

131 Branches

446 Tags

325 MiB

Tree: e4290dec2d

Commit Graph

Author	SHA1	Message	Date
Niklas Ingholt	3326081bd4	doc: recommend using port 0 instead of common.PORT In the 'writing_tests' guide it is recommended to use common.PORT instead of an arbitrary value, but the recommendation is to use port 0 instead and the docs should reflect that. PR-URL: https://github.com/nodejs/node/pull/8694 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Santiago Gimeno <santiago.gimeno@gmail.com> Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com> Reviewed-By: Ilkka Myller <ilkka.myller@nodefield.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com>	9 years ago
Santiago Gimeno	b83b363839	doc,test: add `How to write a Node.js test` guide PR-URL: https://github.com/nodejs/node/pull/6984 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Yorkie Liu <yorkiefixer@gmail.com>	9 years ago

Author

SHA1

Message

Date

Niklas Ingholt

3326081bd4

doc: recommend using port 0 instead of common.PORT

In the 'writing_tests' guide it is recommended to use common.PORT
instead of an arbitrary value, but the recommendation is to use
port 0 instead and the docs should reflect that.

PR-URL: https://github.com/nodejs/node/pull/8694
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Santiago Gimeno <santiago.gimeno@gmail.com>
Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
Reviewed-By: Ilkka Myller <ilkka.myller@nodefield.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>

9 years ago

Santiago Gimeno

b83b363839

doc,test: add `How to write a Node.js test` guide

PR-URL: https://github.com/nodejs/node/pull/6984
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Yorkie Liu <yorkiefixer@gmail.com>

9 years ago

2 Commits (e4290dec2df252cbaaf79098784730924153b182)