lukechilds/node - node - Gitea: Git with a cup of tea

16724 Commits

131 Branches

446 Tags

325 MiB

Tree: e494e427c9

Commit Graph

Author SHA1 Message Date

Author	SHA1	Message	Date
cjihrig	aa0e4f3843	test: use common.fail() instead of assert(false) PR-URL: https://github.com/nodejs/node/pull/10899 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Italo A. Casas <me@italoacasas.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>	8 years ago
Sam Roberts	822bbe0bb2	test: fix linting for test-tls-add-ca-cert.js Fix lint error introduced in `ea72331af` PR-URL: https://github.com/nodejs/node/pull/10771 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net>	8 years ago
Sam Roberts	ea72331afc	test: check tls server verification with addCACert SecureContext.addCACert() adds to the existing root store, preserving root cert entries. option.ca is applied without calling SecureContext.addRootCerts() so should add to the default, empty, root store. This test confirms that the built-in root CAs are not included when options.ca is used. Based on: `acd5837fd7` PR-URL: https://github.com/nodejs/node/pull/10389 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com> Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>	8 years ago

cjihrig

aa0e4f3843

test: use common.fail() instead of assert(false)

PR-URL: https://github.com/nodejs/node/pull/10899
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Italo A. Casas <me@italoacasas.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>

8 years ago

Sam Roberts

822bbe0bb2

test: fix linting for test-tls-add-ca-cert.js

Fix lint error introduced in ea72331af

PR-URL: https://github.com/nodejs/node/pull/10771
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>

8 years ago

Sam Roberts

ea72331afc

test: check tls server verification with addCACert

SecureContext.addCACert() adds to the existing root store,
preserving root cert entries. option.ca is applied without
calling SecureContext.addRootCerts() so should add to
the default, empty, root store.

This test confirms that the built-in root CAs are not included
when options.ca is used.

Based on:

acd5837fd7

PR-URL: https://github.com/nodejs/node/pull/10389
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>

8 years ago

3 Commits (e494e427c93a55d8f716e9d771324bc5837c79a8)