lukechilds/node - node - Gitea: Git with a cup of tea

Author	SHA1	Message	Date
John Barboza	106d09ab7a	test: check fd 0,1,2 are used, not access mode Don't do a write on stdout/stderr because that checks for their writability. But fd=1 could legitimately be opened with read-only access by the user. All this test needs to ensure is that they are used at startup. PR-URL: https://github.com/nodejs/node/pull/10339 Fixes: https://github.com/nodejs/node/issues/10234 Reviewed-By: Sam Roberts <vieuxtech@gmail.com> Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com> Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: James M Snell <jasnell@gmail.com>	8 years ago
Rich Trott	e65a2d7ddc	test: accept expected AIX result test-stdio-closed AIX handles closed stdio differently (but still compliant with spec as far as I can tell) than other POSIX variants we test. Test results are different than Linux and others because AIX takes measures to not re-use the file descriptors for stdio if one of the stdio streams is closed. Fixes: https://github.com/nodejs/node/issues/8375 PR-URL: https://github.com/nodejs/node/pull/8755 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com> Reviewed-By: Ilkka Myller <ilkka.myller@nodefield.com>	9 years ago
Jeremiah Senkpiel	52bae222a3	test: abstract skip functionality to common The tap skipping output is so prevalent yet obscure in nature that we ought to move it into it's own function in test/common.js PR-URL: https://github.com/nodejs/node/pull/6697 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Santiago Gimeno <santiago.gimeno@gmail.com> Reviewed-By: Fedor Indutny <fedor.indutny@gmail.com>	9 years ago
Rich Trott	9534f6dfd5	tools: enable additional lint rules Enable additional likely-uncontroversial lint rules: * `comma-dangle` set to prohibit dangling commas on objects and arrays that are defined on a single line. Multi-line definitions can use or omit a trailing comma. * `no-unused-labels` Prohibits defining a label that is not used. * `no-path-concat` Prohibits string-concatenation using i`__dirname` and `__filename`. Use `path.join()`, `path.resolve()`, or template strings instead. * `no-new-symbol` disallow use of `new` operator with `Symbol` object. Violating this rule would result in a `TypeError` at runtime.` PR-URL: https://github.com/nodejs/node/pull/5357 Reviewed-By: Rod Vagg <rod@vagg.org> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Michaël Zasso <mic.besace@gmail.com>	9 years ago
Sakthipriyan Vairamani	d5ab92bcc1	test: use common.isWindows consistently In the tests, we use "process.platform === 'win32'" in some places. This patch replaces them with the "common.isWindows" for consistency. PR-URL: https://github.com/nodejs/io.js/pull/2269 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>	10 years ago
Sakthipriyan Vairamani	69298d36cf	test: formatting skip messages for TAP parsing This patch makes the skip messages consistent so that the TAP plugin in CI can parse the messages properly. The format will be 1..0 # Skipped: [Actual reason why the test is skipped] PR-URL: https://github.com/nodejs/io.js/pull/2109 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Johan Bergström <bugs@bergstroem.nu>	10 years ago
Roman Reiss	f29762f4dd	test: enable linting for tests Enable linting for the test directory. A number of changes was made so all tests conform the current rules used by lib and src directories. The only exception for tests is that unreachable (dead) code is allowed. test-fs-non-number-arguments-throw had to be excluded from the changes because of a weird issue on Windows CI. PR-URL: https://github.com/nodejs/io.js/pull/1721 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>	10 years ago
Ben Noordhuis	506c7fd40b	test: fix infinite spawn cycle in stdio test Fix parallel/test-stdio-closed introduced in commit `b5f25a9` ("src: ensure that file descriptors 0-2 are valid") to not keep spawning child processes ad infinitum. The test spawns itself as a child process but a missing return statement made the child process spawn itself again, and again, and again. It went unnoticed for some time because the child process exits almost immediately afterwards, i.e. it didn't fill up the process table. The observable effect was an iojs process that was quietly consuming CPU cyles in the background with a PID that was constantly changing. Refs: https://github.com/iojs/io.js/pull/938 PR-URL: https://github.com/iojs/io.js/pull/948 Reviewed-By: Fedor Indutny <fedor@indutny.com>	10 years ago
Ben Noordhuis	b5f25a963c	src: ensure that file descriptors 0-2 are valid Check that stdin, stdout and stderr map to open file descriptors and remap them to /dev/null if that isn't the case. Protects against information leaks or worse when io.js is started with closed stdio file descriptors. PR-URL: https://github.com/iojs/io.js/pull/875 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Vladimir Kurchatkin <vladimir.kurchatkin@gmail.com>	10 years ago