lukechilds/node - node - Gitea: Git with a cup of tea

15890 Commits

131 Branches

446 Tags

325 MiB

Tree: e59697c695

Commit Graph

Author	SHA1	Message	Date
jessicaquynh	87285ed984	tools: avoid let in for loops This adds a new ESLint tool to check for let declarations within the for, forIn, forOf expressions. Fixes: https://github.com/nodejs/node/issues/9045 Ref: https://github.com/nodejs/node/pull/8873 PR-URL: https://github.com/nodejs/node/pull/9049 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Myles Borins <myles.borins@gmail.com> Reviewed-By: Teddy Katz <teddy.katz@gmail.com> Reviewed-By: Prince John Wesley <princejohnwesley@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>	9 years ago
James M Snell	9e30129fa7	tools: add buffer-constructor eslint rule Now that the Buffer.alloc, allocUnsafe, and from methods have landed, add a linting rule that requires their use within lib. Tests and benchmarks are explicitly excluded by the rule. PR-URL: https://github.com/nodejs/node/pull/5740 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>	9 years ago
Rich Trott	d26417f123	tools: apply custom buffer lint rule to /lib only The lint rule is there to avoid a circular-dependency issue that only applies to `/lib`. In preparation for linting `/benchmark`, apply that rule to `/lib` only to avoid churn in `/benchmark`. Refs: https://github.com/nodejs/node/issues/3983#issuecomment-158956113 PR-URL: https://github.com/nodejs/node/pull/5371 Reviewed-By: Michaël Zasso <mic.besace@gmail.com> Reviewed-By: Roman Reiss <me@silverwind.io>	9 years ago

Author

SHA1

Message

Date

jessicaquynh

87285ed984

tools: avoid let in for loops

This adds a new ESLint tool to check for let
declarations within the for, forIn, forOf expressions.

Fixes: https://github.com/nodejs/node/issues/9045
Ref: https://github.com/nodejs/node/pull/8873
PR-URL: https://github.com/nodejs/node/pull/9049
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Myles Borins <myles.borins@gmail.com>
Reviewed-By: Teddy Katz <teddy.katz@gmail.com>
Reviewed-By: Prince John Wesley <princejohnwesley@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>

9 years ago

James M Snell

9e30129fa7

tools: add buffer-constructor eslint rule

Now that the Buffer.alloc, allocUnsafe, and from methods have landed,
add a linting rule that requires their use within lib. Tests and
benchmarks are explicitly excluded by the rule.

PR-URL: https://github.com/nodejs/node/pull/5740
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>

9 years ago

Rich Trott

d26417f123

tools: apply custom buffer lint rule to /lib only

The lint rule is there to avoid a circular-dependency issue that only
applies to `/lib`. In preparation for linting `/benchmark`, apply that
rule to `/lib` only to avoid churn in `/benchmark`.

Refs: https://github.com/nodejs/node/issues/3983#issuecomment-158956113
PR-URL: https://github.com/nodejs/node/pull/5371
Reviewed-By: Michaël Zasso <mic.besace@gmail.com>
Reviewed-By: Roman Reiss <me@silverwind.io>

9 years ago

3 Commits (e59697c6954e3a9f9c48c74ab8e32698482b9b04)