lukechilds/node - node - Gitea: Git with a cup of tea

13842 Commits

131 Branches

446 Tags

325 MiB

Tree: e673a93cb8

Commit Graph

Author	SHA1	Message	Date
Ali Ijaz Sheikh	b73e1b3c5a	test: fix another flaky stringbytes test Avoid depending on precise timing of when an object will be collected by GC. This test was missed by #6039 as it happened to be in a different directory than the rest. Ref: https://github.com/nodejs/node/pull/6039 PR-URL: https://github.com/nodejs/node/pull/6073 Reviewed-By: Trott - Rich Trott <rtrott@gmail.com>	9 years ago
Ali Ijaz Sheikh	f4ebd5989a	test: fix flakiness of stringbytes-external The tests used to rely on precise timing of when a JavaScript object would be garbage collected to ensure that there is enough memory available on the system. Switch the test to use a malloc/free pair instead. Ref: https://github.com/nodejs/node/pull/5945 PR-URL: https://github.com/nodejs/node/pull/6039 Reviewed-By: jasnell - James M Snell <jasnell@gmail.com> Reviewed-By: evanlucas - Evan Lucas <evanlucas@me.com> Reviewed-By: Trott - Rich Trott <rtrott@gmail.com>	9 years ago

Author

SHA1

Message

Date

Ali Ijaz Sheikh

b73e1b3c5a

test: fix another flaky stringbytes test

Avoid depending on precise timing of when an object will be collected
by GC. This test was missed by #6039 as it happened to be in a
different directory than the rest.

Ref: https://github.com/nodejs/node/pull/6039
PR-URL: https://github.com/nodejs/node/pull/6073
Reviewed-By: Trott - Rich Trott <rtrott@gmail.com>

9 years ago

Ali Ijaz Sheikh

f4ebd5989a

test: fix flakiness of stringbytes-external

The tests used to rely on precise timing of when a JavaScript object
would be garbage collected to ensure that there is enough memory
available on the system. Switch the test to use a malloc/free pair
instead.

Ref: https://github.com/nodejs/node/pull/5945
PR-URL: https://github.com/nodejs/node/pull/6039
Reviewed-By: jasnell - James M Snell <jasnell@gmail.com>
Reviewed-By: evanlucas - Evan Lucas <evanlucas@me.com>
Reviewed-By: Trott - Rich Trott <rtrott@gmail.com>

9 years ago

2 Commits (e673a93cb8ec88447de8a978d1f23b975b2305ea)